Skip to content

Site Editor: Add new 'Push changes to Global Styles' button #46446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noisysocks merged 13 commits into from
Dec 16, 2022
Merged

Site Editor: Add new 'Push changes to Global Styles' button #46446

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b71ba6f
Rough attempt at 'Push changes to Global Styles' button
noisysocks Dec 9, 2022
88769a4
Trying to get presets to be copied over to global styles
ramonjd Dec 9, 2022
e253915
Styles needs default value for when only a preset is updated
ramonjd Dec 9, 2022
277d3e5
Show success toast with undo button for now
noisysocks Dec 12, 2022
3f4bea1
Disable button when there are no changes to push
noisysocks Dec 13, 2022
1ed8b2b
Don't create undo levels
noisysocks Dec 13, 2022
fda09e8
Guard against blockGap which isn't supported
noisysocks Dec 13, 2022
d587847
Don't show style names to user. They can't be localised
noisysocks Dec 13, 2022
44ad315
Styling tweaks
noisysocks Dec 13, 2022
824353d
Add basic E2E test for the happy path
noisysocks Dec 15, 2022
44d0345
we need to handle an undefined argument, for example, when only a pre…
ramonjd Dec 16, 2022
8a80df4
Revert package-lock.json
noisysocks Dec 16, 2022
939b7cd
Adjust copy
noisysocks Dec 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Styles needs default value for when only a preset is updated
  • Loading branch information
@ramonjd
ramonjd committed Dec 9, 2022
commit e25391558b6d017a86417d296005613f7da194f5
2 changes: 1 addition & 1 deletion packages/edit-site/src/hooks/push-changes-to-global-styles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ function usePushBlockStylesToUserStyles( { name, attributes, setAttributes } ) {
useContext( GlobalStylesContext );

return () => {
const { style: blockStyles } = attributes;
const { style: blockStyles = {} } = attributes;

let newBlockStyles = null;
let newUserConfig = null;
Expand Down