Global Styles REST API endpoint: check custom CSS is included before attempting to validate #46561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…attempting to validate
andrewserong
added
[Type] Bug
glendaviesnz
approved these changes
Dec 15, 2022
Contributor
glendaviesnz
left a comment
glendaviesnz
left a comment
There was a problem hiding this comment.
Thanks for catching this!
Tests well for me:
✅ In a blocks theme made an update to global styles without adding any custom CSS - saved without PHP warnings
✅ Added custom CSS - saved without PHP warnings
andrewserong
added
the
Backport to Gutenberg RC
Contributor
|
@ryanwelcher can we please get this one cherry-picked into the 14.8 release? |
andrewserong
deleted the
fix/php-warning-when-saving-global-styles-without-custom-css
branch
dmsnell
pushed a commit
that referenced
this pull request
Dec 15, 2022
…attempting to validate (#46561) * Global Styles REST API endpoint: check custom CSS is included before attempting to validate * Fix linting issue
ryanwelcher
pushed a commit
that referenced
this pull request
Dec 20, 2022
…attempting to validate (#46561) * Global Styles REST API endpoint: check custom CSS is included before attempting to validate * Fix linting issue
Contributor
|
I just cherry-picked this PR to the release/14.8 branch to get it included in the next release: 6ce4f45 |
ryanwelcher
removed
the
Backport to Gutenberg RC
This was referenced Jan 13, 2023
85 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow up to #46141 to make sure that
$request['styles']['css']is set before attempting to validate it.Why?
Without an additional check, saving global styles without custom CSS values resulted in a PHP warning being thrown:
How?
Add an
isset()check before attempting to validate the custom CSS in global styles.Testing Instructions