Skip to content

Block Selection Toolbar: Support fixed and sticky blocks by flipping when there is not enough space above the block #46565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrewserong wants to merge 4 commits into from
Closed

Block Selection Toolbar: Support fixed and sticky blocks by flipping when there is not enough space above the block #46565

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
64160db
Block Selection Toolbar: Support fixed and sticky blocks by re-render…
andrewserong Dec 14, 2022
e32d52f
Add inline comments
andrewserong Dec 15, 2022
f892ec1
Add scrollContainer to deps array
andrewserong Jan 4, 2023
9c63677
Remove no longer needed changes to block popover
andrewserong Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove no longer needed changes to block popover
  • Loading branch information
@andrewserong
andrewserong committed Jan 4, 2023
commit 9c6367772995d55a28fb063c3216c6ef98470e0b
29 changes: 0 additions & 29 deletions packages/block-editor/src/components/block-popover/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import classnames from 'classnames';
* WordPress dependencies
*/
import { useMergeRefs } from '@wordpress/compose';
import { getScrollContainer } from '@wordpress/dom';
import { Popover } from '@wordpress/components';
import {
forwardRef,
Expand Down Expand Up @@ -76,34 +75,6 @@ function BlockPopover(
};
}, [ selectedElement ] );

// Get the scrollable container that the block popover appears within.
const scrollContainer = useMemo( () => {
if ( ! __unstableContentRef?.current ) {
return;
}
return getScrollContainer( __unstableContentRef?.current );
}, [ __unstableContentRef?.current ] );

// Force the block popover to re-render whenever the content area is scrolled.
// This ensures that the position of the popover is accurate for fixed or sticky blocks.
useLayoutEffect( () => {
if ( ! scrollContainer ) {
return;
}

scrollContainer?.addEventListener?.(
'scroll',
forceRecomputePopoverDimensions
);

return () => {
scrollContainer?.removeEventHandler?.(
'scroll',
forceRecomputePopoverDimensions
);
};
}, [ scrollContainer ] );

const style = useMemo( () => {
if (
// popoverDimensionsRecomputeCounter is by definition always equal or greater
Expand Down