Skip to content

Global styles: enable user global styles revisions #46667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ramonjd wants to merge 23 commits into from
Closed

Global styles: enable user global styles revisions #46667

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
ab00625
Initial commit
ramonjd Dec 20, 2022
241460c
Updating test
ramonjd Dec 20, 2022
0ba94e6
Sending and checking for settings as well since some style variations…
ramonjd Dec 21, 2022
7dcf0d0
Added a new endpoint to the global styles rest API (/revisions)
ramonjd Dec 22, 2022
f56cb4e
revisions is no longer a property of the response object
ramonjd Dec 22, 2022
fcfed1a
Update description for rest param
ramonjd Dec 23, 2022
025fcf5
There's no reason to use the stored userConfig at all if we're reinst…
ramonjd Dec 23, 2022
59cb723
added a test for the revisions endpoint
ramonjd Dec 23, 2022
af7420e
Added text domain
ramonjd Dec 23, 2022
9728372
Bumping minimum revision count until display to two:
ramonjd Dec 23, 2022
eeab42f
Added a very unpretty E2E test for global styles revisions. We can't …
ramonjd Dec 29, 2022
75b579f
Formatting the comments in the E2E test.
ramonjd Dec 29, 2022
7003d22
Fixing up things after a rebase, mainly usage of __experimentalGetCur…
ramonjd Apr 5, 2023
08a3eed
Moving changes to global styles controller to 6.2 compat
ramonjd Apr 5, 2023
363105d
JS LINT YO!
ramonjd Apr 5, 2023
a7a47df
Relocate js utils tests for isGlobalStyleConfigEqual
ramonjd Apr 5, 2023
760ae90
Move rest route registration to compat 6.3
ramonjd Apr 5, 2023
4b1b41d
update e2e tests so that they pass :D I was importing a non-existant …
ramonjd Apr 11, 2023
c1bb9f8
Testing with undo/reset buttons
ramonjd Apr 11, 2023
3a6c161
Moving the revisions link so that it's under the drop down
ramonjd Apr 12, 2023
461d7ad
Yoda?
ramonjd Apr 12, 2023
408a755
Adding author display name and avatar to rest response
ramonjd Apr 13, 2023
6445d13
Update PHP tests title > date
ramonjd Apr 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update PHP tests title > date
  • Loading branch information
@ramonjd
ramonjd committed Apr 14, 2023
commit 6445d139ec02b9794d34aab6a86504acfbdcd9bf
4 changes: 2 additions & 2 deletions phpunit/class-gutenberg-rest-global-styles-controller-test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,8 @@ public function test_get_item_revisions() {

$this->assertCount( 1, $data, 'Check that only one revision exists' );
$this->assertArrayHasKey( 'id', $data[0], 'Check that an id key exists' );
$this->assertArrayHasKey( 'raw', $data[0]['title'], 'Check that a raw title key exists' );
$this->assertArrayHasKey( 'rendered', $data[0]['title'], 'Check that a rendered title key exists' );
$this->assertArrayHasKey( 'raw', $data[0]['date'], 'Check that a raw title key exists' );
$this->assertArrayHasKey( 'rendered', $data[0]['date'], 'Check that a rendered title key exists' );
$this->assertEquals(
$data[0]['settings'],
new stdClass(),
Expand Down