Style book: Hide inline preview when style book is open #46705
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +194 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
noisysocks
reviewed
Jan 30, 2023
| } | ||
|
|
||
| function StyleBook( { isSelected, onSelect, onClose } ) { | ||
| function StyleBook( { selectedBlockPath, onSelect, onClose } ) { |
Member
There was a problem hiding this comment.
I don't think StyleBook should be concerned with what a "path" is. StyleBook can be rendered in any context independently of whether or not a Navigator is used. I suggest instead adding a selectedCategory: string or isCategorySelected: ( category: string ) => boolean prop to StyleBook and moving the path logic up one level.
Member
Author
|
It is good to have both as per the discussion here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #46394
Note: included a change to common component
TabsPanelin this PR for testing purposes. Created #46704 for this change.Testing Instructions
Screenshots or screencast