Dashicon: remove unnecessary type for className prop#46849
Merged
Conversation
ciampo
added
[Type] Code Quality
tyxla
approved these changes
Jan 3, 2023
Member
tyxla
left a comment
tyxla
left a comment
There was a problem hiding this comment.
Good find 👍 className is already provided by the HTMLAttributes interface, implemented (directly or indirectly) by the types of all React HTML elements.
Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
ciampo
changed the title
classname propclassName prop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to #45924
Remove unnecessary prop for
classname, which is already included in the component props when using theWordrpressComponentPropsutility type.Why?
Code cleanup
How?
Deleted prop type declaration.
Testing Instructions
Project builds without TS errors