[Components - Placeholder]: Set fixed right margin for label's icon#46918
Merged
ntsekouras merged 3 commits intotrunkfrom Jan 5, 2023
Merged
[Components - Placeholder]: Set fixed right margin for label's icon#46918ntsekouras merged 3 commits intotrunkfrom
ntsekouras merged 3 commits intotrunkfrom
Conversation
ntsekouras
added
[Type] Bug
Contributor
That makes more sense to me. |
|
Size Change: -3 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 612310a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3849025305
|
Contributor
Author
I updated to use |
ntsekouras
force-pushed
the
fix/placeholder-icon-margin-with-dashicons
branch
from
2fcd070 to
612310a
Compare
ntsekouras
changed the title
mirka
approved these changes
Jan 5, 2023
Member
mirka
left a comment
mirka
left a comment
There was a problem hiding this comment.
Looks good, makes sense 👍
Just noting that $grid-unit-15 is 12px, not 14px. Which matches our standard 4px grid, so it's good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #45360
Fixes: #36836
The Placeholder component adds margin-right to its icon but uses
chunit, which is defined as the width of the character 0 which indashiconsis0. This PR changes the margin to be the same for all cases(12pxvalue) .Testing Instructions
chart-barand insert a Query Loop block