Remove @storybook/addon-knobs from the repository#47152
Merged
Conversation
ciampo
added
[Type] Code Quality
Contributor
Author
|
Size Change: +266 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7184657. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3939754357
|
Member
|
I'm refraining from a review while this is a draft, but please feel free to re-request one once this is ready, @ciampo. |
ciampo
force-pushed
the
remove/storybook-addons-knobs
branch
from
9deb67a to
39c0f08
Compare
Contributor
Author
|
All knobs usages should have been migrated. Time to give this PR a review! |
Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
Contributor
Author
|
Thank you! I applied your change, will merge as soon as CI is ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Remove the
@storybook/addon-knobsdependency from the repositoryWhy?
The dependency has been deprecated for a long time, and we recently removed all usages from all Storybook examples.
This dependency is currently blocking using npm 8 (see #46443)
How?
Removed from:
Testing Instructions
trunktrunk