Skip to content

Upgrade Jest from 27 to 29.5.0 #47388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsnajdr merged 12 commits into from
Mar 8, 2023
Merged

Upgrade Jest from 27 to 29.5.0 #47388

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4024a2c
Upgrade Jest and friends to 29.5.0
jsnajdr Jan 23, 2023
c361279
Update lockfile
jsnajdr Jan 23, 2023
435ab38
Migrate the testURL option
jsnajdr Jan 23, 2023
340ad71
Custom resolver to solve ESM+browser modules
jsnajdr Jan 23, 2023
ec085d5
Use new API to enable legacy fake timers
jsnajdr Jan 23, 2023
712d322
isURL tests: remove controversial IPv4-like URLs where the spec recen…
jsnajdr Jan 23, 2023
ef772bf
Fix mobile unit tests
jsnajdr Jan 24, 2023
da5e53f
jest-environment-puppeteer: fix ESM import of jest-environment-node
jsnajdr Feb 24, 2023
a1aae27
Add Babel config for e2e-tests that babel-jest can find
jsnajdr Feb 24, 2023
7be547a
Remove legacy timers option (real is the default)
jsnajdr Feb 24, 2023
785b2d2
Mobile tests: fix ESM import for jest-environment-jsdom
jsnajdr Feb 24, 2023
61aa916
Add changelog entries and update docs
jsnajdr Mar 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add Babel config for e2e-tests that babel-jest can find
  • Loading branch information
@jsnajdr
jsnajdr committed Mar 8, 2023
commit a1aae27cb398e201cdaaf8397babb85f946fde53
7 changes: 7 additions & 0 deletions packages/e2e-tests/babel.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
module.exports = ( api ) => {
api.cache( true );
Copy link
Member

@tyxla tyxla Feb 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

I can't think of a scenario where we'd actually want to cache the config per environment with api.cache.using( () => process.env.NODE_ENV ).

I wonder if enabling this config cache was motivated by something and whether this change affects the performance of the e2e tests.

Copy link
Member

@gziolo gziolo Feb 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's for the test suites' source code. Isn't it always equal to test?

Copy link
Member Author

@jsnajdr jsnajdr Feb 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I admin I didn't think about proper caching at all when writing this 🙂 I just copied a statement that every other Babel config in the repo also uses.

Copy link
Member

@tyxla tyxla Feb 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's for the test suites' source code. Isn't it always equal to test?

Yup, that's what I essentially was saying with:

I can't think of a scenario where we'd actually want to cache the config per environment with api.cache.using( () => process.env.NODE_ENV ).


return {
presets: [ '@wordpress/babel-preset-default' ],
};
};