Skip to content

Move custom css to its own inline style generation method and combine with customizer CSS #47396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glendaviesnz merged 7 commits into from
Jan 31, 2023
Merged

Move custom css to its own inline style generation method and combine with customizer CSS #47396

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c7787b0
Move custom css to its on inline style at bottom of header
glendaviesnz Jan 25, 2023
c2ecf73
Fix linting issues
glendaviesnz Jan 25, 2023
d8debd6
Also move block custom CSS to separate stylesheet
glendaviesnz Jan 25, 2023
f0597dc
Update test
glendaviesnz Jan 25, 2023
f67ba8c
Switch from `wp_enqueue_style` to just outputting the style tags in o…
glendaviesnz Jan 25, 2023
317c39e
Move to 6.2 script-loader compat file
glendaviesnz Jan 26, 2023
3b44904
Global Styles: Alternative method for enqueueing custom CSS (#47554)
Mamaduka Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Switch from wp_enqueue_style to just outputting the style tags in o… 
…rder to get the output in the correct place after the customizer css
  • Loading branch information
@glendaviesnz
glendaviesnz committed Jan 25, 2023
commit f67ba8c9b65f803a5b6acef3d99c6ab65ed55d1c
8 changes: 5 additions & 3 deletions lib/compat/wordpress-6.1/script-loader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,11 @@ function gutenberg_enqueue_global_styles_custom_css() {
$custom_css = get_global_styles_custom_css();
$is_block_theme = wp_is_block_theme();
if ( $custom_css && $is_block_theme ) {
wp_register_style( 'global-styles-custom-css', false, array(), true, true );
wp_add_inline_style( 'global-styles-custom-css', $custom_css );
wp_enqueue_style( 'global-styles-custom-css' );
?>
Copy link
Contributor Author

@glendaviesnz glendaviesnz Jan 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outputting the style element here, instead of using wp_enqueue_style was the only way I could get this to load in the header after the customizer custom CSS - there may be a better approach that I am overlooking

<style id="global-styles-custom-css-inline-css" type="text/css">
<?php echo $custom_css; ?>
</style>
<?php
}
}

Expand Down