Skip to content

Add placeholder functionality to Editable component #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ellatrix wants to merge 18 commits into from
Closed

Add placeholder functionality to Editable component #475

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
ae8ca4c
First try for placeholders
ellatrix May 4, 2017
ac64bae
Sync content and selection to state
ellatrix May 5, 2017
53e32e3
Use Array.from to get child node index
ellatrix May 5, 2017
a94a380
Make sure the editor is focussed before applying formatting
ellatrix May 5, 2017
1723d99
Set local content state on setContent
ellatrix May 5, 2017
00e812b
Simplify getSelection, fixes bug with <br>
ellatrix May 5, 2017
1baeb37
Invert comparison
ellatrix May 5, 2017
7b59414
Don't rely on globals to determine active state
ellatrix May 5, 2017
930b462
Only trigger change on TinyMCE change, and pass selection as well
ellatrix May 8, 2017
1d2df5a
Simplify isEmpty check and change state if it changes
ellatrix May 8, 2017
8a5923b
Fix focus when merging text blocks
ellatrix May 9, 2017
5679973
Make isActive check actual focussed node
ellatrix May 9, 2017
e6e0266
Content can be null
ellatrix May 9, 2017
59ba2f3
Simplify selection setting
ellatrix May 9, 2017
9470613
Properly center caption placeholders
ellatrix May 9, 2017
02b4fc2
Move range logic to separate file
ellatrix May 10, 2017
d81a2b6
Use componentWillReceiveProps for manipulation instead of shouldCompo…
ellatrix May 10, 2017
ec72213
Only sync changes on blur
ellatrix May 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Content can be null
  • Loading branch information
@ellatrix
ellatrix committed May 10, 2017
commit e6e0266482fe7cb7de40de563edb6fecaaacf39e
2 changes: 1 addition & 1 deletion blocks/editable/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ export default class Editable extends wp.element.Component {
}

isEmpty( content ) {
return ! content.length;
return ! content || ! content.length;
}

render() {
Expand Down