Navigation: Always create a fallback menu #47684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Flaky tests detected in 3a5252b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4192731842
|
|
Size Change: +30 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
draganescu
reviewed
Feb 3, 2023
draganescu
reviewed
Feb 3, 2023
draganescu
reviewed
Feb 3, 2023
draganescu
reviewed
Feb 3, 2023
Contributor
|
A problem with this is that I cannot ever be in a state where I have no block menus. In the editor if I delete the last block navigation it will just create a new one with a page list in it. |
Contributor
Author
Yes, when you try to use it. Is that a problem? |
scruffian
force-pushed
the
add/create-fallback-navigation
branch
from
c536475 to
3b5a0a9
Compare
Contributor
|
Actually I am wrong @scruffian because if I have block navigation then the block has a ref and when I delete the menu that the ref points to I get the warning. If there are no menus that I can switch to, I see the warning and I can:
Cool! 👍🏻 |
draganescu
previously requested changes
Feb 3, 2023
Contributor
Author
Good catch. Fixed in 4fd95cb |
Contributor
|
@scruffian this PR should also remove the current page list fallback behavior . 🙏🏻 |
Contributor
Author
|
I think this is ready for another review. |
scruffian
force-pushed
the
add/create-fallback-navigation
branch
from
3a15b83 to
3d041f2
Compare
draganescu
reviewed
Feb 9, 2023
Contributor
|
Contributor
Author
|
I added a commit to fix the tests. |
kevin940726
reviewed
Feb 10, 2023
scruffian
force-pushed
the
add/create-fallback-navigation
branch
from
716f4ec to
e072b47
Compare
Contributor
Author
This is not what happens in my testing. |
scruffian
force-pushed
the
add/create-fallback-navigation
branch
2 times, most recently
from
01988b7 to
083adec
Compare
scruffian
force-pushed
the
add/create-fallback-navigation
branch
from
1d59818 to
3a5252b
Compare
Member
|
@draganescu It's not very RESTful, I'd probably just make a one-off endpoint in |
scruffian
force-pushed
the
add/create-fallback-navigation
branch
from
3a5252b to
f5fe083
Compare
Contributor
|
@TimothyBJacobs a one off endpoint in |
Contributor
|
@draganescu Right so a REST endpoint that you can query and say get me a fallback menu and it will return one. Can be used in editor and front of site. This would
|
Contributor
Author
|
This PR creates multiple wp_navigation CPTs when there are multiple blocks in the same post. Reverting in #48602 until we have a way to deal with that problem. |
dsas
added a commit
to Automattic/jetpack
that referenced
this pull request
Jun 11, 2025
This code doesn't work, and even if it did it's a hack that is probably overly broad. In the past a fallback navigation was created when one didn't exist. This used to be created in `render_block_core_navigation` (see WordPress/gutenberg#47684) but no longer happens. This has lead to a number of blogs having this fallback navigation created when an a12 visited their site. This means that the a12s details - wpcom username, email address etc are in the generated export file. It feels unhelpful to have this in the export file, partly because it might need explaining if the legal time share an export as part of a legal request, and partly because a12s data is shared to anyone exporting an affected blog. This change tries to remove the information when generating the export file, but is somewhat hampered by a lack of relevent hooks and also by a way of identifying current and former a12s. Instead it chooses a relevant SQL generation, hackily identifies whether the query is the relevant part of the export, and then modifies it to add some SQL excluding wp_navigation post types that were created by users that are not currently part of the blog. See also https://linear.app/a8c/issue/DOTCOM-13020
3 tasks
dsas
added a commit
to Automattic/jetpack
that referenced
this pull request
Jun 20, 2025
This code doesn't work, and even if it did it's a hack that is probably overly broad. In the past a fallback navigation was created when one didn't exist. This used to be created in `render_block_core_navigation` (see WordPress/gutenberg#47684) but no longer happens. This has lead to a number of blogs having this fallback navigation created when an a12 visited their site. This means that the a12s details - wpcom username, email address etc are in the generated export file. It feels unhelpful to have this in the export file, partly because it might need explaining if the legal time share an export as part of a legal request, and partly because a12s data is shared to anyone exporting an affected blog. This change tries to remove the information when generating the export file, but is somewhat hampered by a lack of relevent hooks and also by a way of identifying current and former a12s. Instead it chooses a relevant SQL generation, hackily identifies whether the query is the relevant part of the export, and then modifies it to add some SQL excluding wp_navigation post types that were created by users that are not currently part of the blog. See also https://linear.app/a8c/issue/DOTCOM-13020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This creates a fallback navigation CPT when there isn't one. Fixes #47058
Why?
This should simplify several things
How?
We automatically create a wp_navigation CPT in both the editor and the frontend, if a user doesn't have one.
Testing Instructions
Testing Instructions for Keyboard
As above.