Skip to content

Conversation

@dmsnell
Copy link
Member

@dmsnell dmsnell commented Apr 20, 2017

No description provided.

@dmsnell dmsnell force-pushed the grammar/syntax-updates branch from 112430e to 629e9e7 Compare April 20, 2017 22:19
@dmsnell dmsnell requested review from aduth and youknowriad April 20, 2017 22:25
@aduth
Copy link
Member

aduth commented Apr 20, 2017

I have no context for the motivation or impact of this change.

.gitignore Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be in the same pull request as a proposed code change, a separate pull request "if any".

This really should be added to your global .gitignore, there are too many IDEs and Editors to accomadate, see https://core.trac.wordpress.org/changeset/35254

@dmsnell
Copy link
Member Author

dmsnell commented Apr 21, 2017

I have no context for the motivation or impact of this change.

@aduth just a little cleanup to a simpler way - shouldn't cause any functional changes

@nylen
Copy link
Member

nylen commented Apr 21, 2017

From https://pegjs.org/documentation#grammar-syntax-and-semantics:

$ expression
Try to match the expression. If the match succeeds, return the matched text instead of the match result.

Remove the .idea change and :shipit:

@dmsnell dmsnell force-pushed the grammar/syntax-updates branch from 629e9e7 to 29d2df8 Compare April 22, 2017 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants