BorderBoxControl: migrate tests to TypeScript, remove act() call#47755
Merged
BorderBoxControl: migrate tests to TypeScript, remove act() call#47755
act() call#47755Conversation
ciampo
added
[Type] Code Quality
ciampo
commented
Feb 4, 2023
|
Size Change: 0 B Total Size: 1.31 MB ℹ️ View Unchanged
|
|
Flaky tests detected in c1b1d9b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4105491572
|
Contributor
There was a problem hiding this comment.
Thanks for finishing off the conversion of the BorderBoxControl to TypeScript @ciampo 👍
The changes look good.
✅ No typing errors
✅ Unit tests are passing locally.
✅ Updates look good. No runtime changes.
Regarding the remaining timeout error in the failed e2e, that looks related to a different test than the one commented on in this PR. I couldn't, however, replicate the problem locally. 🤔
tyxla
reviewed
Feb 6, 2023
Member
There was a problem hiding this comment.
I've noticed that this test times out on CI (not locally though) so in bde3e09 I've split it to separate tests that target each button separately. This should distribute the effort and make tests run within the 5s limit.
Contributor
Author
There was a problem hiding this comment.
That fixed it, thank you!
tyxla
approved these changes
Feb 6, 2023
Member
tyxla
left a comment
tyxla
left a comment
There was a problem hiding this comment.
I've added a commit to fix the test timeout and left some thoughts, but this looks great IMHO 👍 🚀 Nice work
Member
There was a problem hiding this comment.
We could be able to shorten this to a single query, where:
const solidButton = screen.queryByRole( 'button', {
name: 'Solid',
} );
const dashedButton = screen.queryByRole( 'button', {
name: 'Dashed',
} );
const dottedButton = screen.queryByRole( 'button', {
name: 'Dotted',
} );
expect( solidButton ).not.toBeInTheDocument();
expect( dashedButton ).not.toBeInTheDocument();
expect( dottedButton ).not.toBeInTheDocument();
to:
const styleButton = screen.queryByRole( 'button', {
name: /(Solid)|(Dashed)|(Dotted)/,
} );
expect( styleButton ).not.toBeInTheDocument();
This is totally optional since it's a suggestion on pre-existing code.
Member
There was a problem hiding this comment.
Nice. You might also want to do it for the other should omit style options when requested test that has the same assertions.
ciampo
force-pushed
the
refactor/border-box-control-finish-ts-migration
branch
2 times, most recently
from
07a6e71 to
fdbd422
Compare
ciampo
force-pushed
the
refactor/border-box-control-finish-ts-migration
branch
from
fdbd422 to
c1b1d9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of #35744
Refactor
BorderBoxControl's tests to TypeScript (the rest of the component is already typed)Remove unnecessary
act()call in the processWhy?
Part of the TypeScript migration that we're doing in the
@wordpress/componentspackage, see #35744 for more infoHow?
Testing Instructions
No runtime changes. Make sure that the project compiles, and that tests make sense