Skip to content

Fix multiple menu creation from unsaved inner blocks in Nav block #47884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
getdave wants to merge 1 commit into from
Closed

Fix multiple menu creation from unsaved inner blocks in Nav block #47884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/block-library/src/navigation/edit/unsaved-inner-blocks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ export default function UnsavedInnerBlocks( {
hasSelection,
} ) {
const originalBlocks = useRef();
const isCreatingMenu = useRef( false );

useEffect( () => {
// Initially store the uncontrolled inner blocks for
Expand Down Expand Up @@ -125,6 +126,8 @@ export default function UnsavedInnerBlocks( {

// Automatically save the uncontrolled blocks.
useEffect( () => {
// Don't allow menus to be created when one is already being created.
//
// The block will be disabled when used in a BlockPreview.
// In this case avoid automatic creation of a wp_navigation post.
// Otherwise the user will be spammed with lots of menus!
Expand All @@ -138,6 +141,7 @@ export default function UnsavedInnerBlocks( {
// And finally only create the menu when the block is selected,
// which is an indication they want to start editing.
if (
isCreatingMenu.current ||
isDisabled ||
isSaving ||
! hasResolvedDraftNavigationMenus ||
Expand All @@ -148,7 +152,13 @@ export default function UnsavedInnerBlocks( {
return;
}

createNavigationMenu( null, blocks );
// Flag that a menu is being created.
isCreatingMenu.current = true;

createNavigationMenu( null, blocks ).finally( () => {
// Flag that a menu is no longer being created.
isCreatingMenu.current = false;
} );
}, [
isDisabled,
isSaving,
Expand Down