Skip to content

Fix: duplicate markup on anchor attribute #48438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
t-hamano wants to merge 9 commits into from
Closed

Fix: duplicate markup on anchor attribute #48438

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
528a08d
Fix: duplicate markup on anchor attribute
t-hamano Feb 25, 2023
86491af
Update block.json schema and documentation
t-hamano Mar 28, 2023
64be272
Re-add gutenberg_register_anchor_support() function
t-hamano Mar 28, 2023
b010478
Changed the value of anchor support for dynamic blocks
t-hamano Mar 28, 2023
3a409ef
Change the definition of attirbutes according to the value of anchor …
t-hamano Mar 28, 2023
99ff106
Fix unit test
t-hamano Mar 28, 2023
cf5a05f
Merge branch 'trunk' into fix/anchor-dynamic-block
t-hamano Jun 2, 2023
36a30e5
Add anchor support to Time To Read block
t-hamano Jun 2, 2023
0e1e05d
Fix incorrect anchor value
t-hamano Jun 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Re-add gutenberg_register_anchor_support() function
  • Loading branch information
@t-hamano
t-hamano committed Mar 28, 2023
commit 64be27289769133c1b7050e2b928c9a0d9f24bd6
25 changes: 24 additions & 1 deletion lib/block-supports/anchor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,28 @@
* @package gutenberg
*/

/**
* Registers the anchor block attribute for block types that support it.
*
* @param WP_Block_Type $block_type Block Type.
*/
function gutenberg_register_anchor_support( $block_type ) {
$has_anchor_support = _wp_array_get( $block_type->supports, array( 'anchor' ), true );
if ( ! $has_anchor_support ) {
return;
}

if ( ! $block_type->attributes ) {
$block_type->attributes = array();
}

if ( ! array_key_exists( 'anchor', $block_type->attributes ) ) {
$block_type->attributes['anchor'] = array(
'type' => 'string',
);
}
}

/**
* Add the anchor to the output.
*
Expand Down Expand Up @@ -39,6 +61,7 @@ function gutenberg_apply_anchor_support( $block_type, $block_attributes ) {
WP_Block_Supports::get_instance()->register(
'anchor',
array(
'apply' => 'gutenberg_apply_anchor_support',
'register_attribute' => 'gutenberg_register_anchor_support',
'apply' => 'gutenberg_apply_anchor_support',
)
);