Image Block: Fix adding an image caption to the image block #488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Bug
Contributor
|
Seems to work great! This is also possibly a thing for a separate PR as this is also an issue with the image caption. But there's no placeholder text in the empty citation field:
It should say "Write citation..." in $light-gray-500 ;) |
jasmussen
approved these changes
Apr 24, 2017
Contributor
Author
Right! waiting for #475 to fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tiny PR fixes adding a caption to an image block with an empty caption. The edited caption was not saved because we're destroying the editor before the
onFocusOut(that triggersonChange) is being called, thus, the value was not saved.You can experience the same bug with the quote citation.