[RNMobile] Add block transforms integration tests for Text blocks #48823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
the
Mobile App - i.e. Android or iOS
fluiddot
changed the base branch from
trunk
to
rnmobile/fix/paragraph-block-transformations
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
fluiddot
force-pushed
the
rnmobile/add/text-block-transformations-tests
branch
from
277f367 to
3e6a14a
Compare
|
Flaky tests detected in fe8eba8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4355823158
|
Base automatically changed from
rnmobile/fix/paragraph-block-transformations
to
trunk
March 7, 2023 15:32
# Conflicts: # packages/block-library/src/paragraph/test/transforms.native.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add integration tests to cover the block transform functionality of Text blocks.
Why?
This PR is a follow-up of #48792 to cover with tests the block transform functionality.
How?
Integration tests have been added to the following Text blocks:
Additionally, two helpers have been added to simplify the test logic:
transformBlock: Transforms a block using the Block actions and Transform menus.getBlockTransformOptions: Returns the transform options. This is used to check that the block transform options of a block match the expected ones.Testing Instructions
Unit tests pass
Unit Tests / Mobilejob pass.Manual test
Follow the change introduced in #48792 that enables more block transforms, it would be great to test the transformations manually to confirm that work as expected.
NOTE: The web version usually displays more options because it supports more blocks. We should only check the supported blocks in the native version.
Here you can check the potential block transformations for the blocks
Paragraph
document.createHTMLDocumentfunction to work.Heading
List
Quote
Preformatted
Shortcode
Verse
Pullquote
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A