[RNMobile] Add block transforms integration tests for Media blocks #48825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
the
Mobile App - i.e. Android or iOS
fluiddot
commented
Mar 7, 2023
test/native/setup.js
Outdated
Comment on lines
+135
to
+142
Contributor
Author
There was a problem hiding this comment.
We need to mock react-native-video as it's the library used to render the video player in the Video block.
test/native/__mocks__/styleMock.js
Outdated
Comment on lines
+178
to
+180
Contributor
Author
There was a problem hiding this comment.
This style is used by the Media & Text block in:
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 6d1997c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4373452450
|
fluiddot
force-pushed
the
rnmobile/add/text-block-transformations-tests
branch
from
277f367 to
3e6a14a
Compare
fluiddot
force-pushed
the
rnmobile/add/media-block-transformations-tests
branch
from
f80ab91 to
344a14b
Compare
derekblank
reviewed
Mar 8, 2023
Member
There was a problem hiding this comment.
This is looking good to me, nice work! I was able to successfully test the manual transforms from the app.
I did want to note one thing, however -- when testing the transform options on the Media & Text block on mobile, I noted that "Video" is present as a transform option, which also matches the web behavior. However, in the dropdown list of block transforms for manual testing and in the Media & Text transforms snapshot, the Video block is not present.
Perhaps the Video block is just missing as a test case transform option here for Media & Text, and the web and mobile behavior is correct? I just wanted to check in case the Video block should not be present as a transform option for the Media & Text block.
Base automatically changed from
rnmobile/add/text-block-transformations-tests
to
trunk
March 8, 2023 09:25
Contributor
Author
Good catch @derekblank. I overlooked the case where the Media & Text block has a video, in that case, it can be transformed into a Video block instead of an Image block. I'll update the test case and integration test, thanks! |
Contributor
Author
|
@derekblank I've just noticed that, when separating the integration tests into PRs, I forgot to include tests for the Cover block. I'll include it in this PR, sorry for the inconvenience 🙇 . |
Contributor
Author
|
Test cases for Media & Text and Cover blocks have been added in: @derekblank let me know if you could take a quick look, thanks for the help 🙇 ! |
derekblank
approved these changes
Mar 9, 2023
Member
derekblank
left a comment
derekblank
left a comment
There was a problem hiding this comment.
LGTM! After the updates, I was able to test all transforms successfully. Thanks for adding these tests. 🚀
fluiddot
force-pushed
the
rnmobile/add/media-block-transformations-tests
branch
from
72ba1f6 to
6d1997c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add integration tests to cover the block transform functionality of Media blocks.
Why?
This PR is a follow-up of #48792 to cover with tests the block transform functionality.
How?
Integration tests have been added to the following Media blocks:
Testing Instructions
Unit tests pass
Unit Tests / Mobilejob pass.Manual test
Follow the change introduced in #48792 that enables more block transforms, it would be great to test the transformations manually to confirm that work as expected.
NOTE: The web version usually displays more options because it supports more blocks. We should only check the supported blocks in the native version.
Here you can check the potential block transformations for the blocks
Image
Video
Media & Text
Gallery
Cover
File
Audio
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A