Private APIs: actions: ensure same function is returned #48937
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +5 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
gziolo
added
[Package] Private APIs
Member
|
That's a good catch. It would make sense to include a new test case that covers |
Contributor
|
Thank you @ellatrix! I agree with the premise. Just pointing out the current implementation breaks a few unit tests. Reviewing this PR in details is on my list, but I didn’t have a chance yet so I’m not sure why these tests break. |
Member
Author
|
Yes, haven't had time to look into the failures yet. |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
While debugging performance on typing, I noticed that the actions returned by
unlockare different between each render. So the following is returning false:This is causing an action to be dispatched on every keystroke in
useVisualizer.The solution is to only run
mapActionsonce when the private APIs are registered.I'm not sure if the way I'm doing this is the best. The problem is that private actions are registered after the store in initialised, so we can't map the actions on store init like the regular ones. IMO, it would be better if private actions are registered at the time of store init, but I realise that there's no store ref to use then.
Why?
When using
useEffect, it's important that the action function remains constant.How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast