Let WP make images responsive #4898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
the
[Feature] Media
mtias
reviewed
Feb 6, 2018
| <img | ||
| src={ url } | ||
| alt={ alt } | ||
| className={ id ? `wp-image-${ id }` : null } |
Member
There was a problem hiding this comment.
wouldn't this invalidate existing image blocks?
Member
Author
There was a problem hiding this comment.
Yes, somehow didn't expect missing attributes to error.
Contributor
This was referenced Mar 26, 2018
4 tasks
|
Hey, does adding this class presume it is full width? Say you had something half the width of the viewport can we account for that too? My images seem bigger than they should be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Let WP make images responsive. WP looks at the class with ID for this.
How Has This Been Tested?
Upload an image, and view on the front-end. Verify it has
srcsetattributes etc.Checklist: