List View: Remove unused selector from the 'useBlockSelection' hook #48984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
|
Size Change: -4 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
Contributor
Member
Author
|
@alexstine, this shouldn't affect any work done that PR. |
alexstine
approved these changes
Mar 14, 2023
Contributor
alexstine
left a comment
alexstine
left a comment
There was a problem hiding this comment.
With the above confirmed, LGTM. 👍
andrewserong
approved these changes
Mar 14, 2023
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
Thanks for spotting this one @Mamaduka — from memory, I was originally playing around with using getBlockSelectionEnd and eventually realised that the end of the selection would always be using clientId or destinationClientId instead, so this looks like a stray leftover from that exploration.
Thanks for the caution @alexstine! From testing this PR out with each of the keyboard and mouse combinations for multi selection within the list view, this change appears safe to me, and doesn't seem to impact the other in progress work.
LGTM!
Member
Author
|
Thanks for the reviews and additional context 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR removes the unused
getBlockSelectionEndselector from the 'useBlockSelection' hook.Why?
I don't believe this selector was ever used (introduced in #38314), so it doesn't affect the
updateBlockSelectioncallback.Testing Instructions
CI tests are passing.