Skip to content

[Github-Actions-Workflows][Plugin-Release] Allow shipping a point-release for an older stable release #49082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fullofcaffeine merged 36 commits into from
Jul 5, 2023
Merged

[Github-Actions-Workflows][Plugin-Release] Allow shipping a point-release for an older stable release #49082

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
8cd1231
Allow point-releases for release branches that are not the latest any…
fullofcaffeine Mar 3, 2023
d685abb
Revert debug changes
fullofcaffeine Mar 14, 2023
8b939f8
Limit runs to `release/` branches
fullofcaffeine Apr 7, 2023
ff5c80f
Fix changelog directory interpolation
fullofcaffeine Apr 7, 2023
489aa70
Re-add debug changes for further testing
fullofcaffeine Apr 7, 2023
9dc4b39
Create only the tag when releasing an older point release, do not cre…
fullofcaffeine Apr 7, 2023
7438230
Implement guard against accidental trunk release of older point releases
fullofcaffeine Apr 15, 2023
237fd16
Attempt to fix "fetch" already defined error when running the script …
fullofcaffeine Apr 15, 2023
8934253
Simplify by not using node-fetch, or it will require installing the npm
fullofcaffeine Apr 15, 2023
0b06966
GH requires an user-agent
fullofcaffeine Apr 15, 2023
2cb1260
Improve var name and comments
fullofcaffeine Apr 18, 2023
1b0713b
Define func to set the output of the "compute-should-update-trunk" jo…
fullofcaffeine Apr 19, 2023
7ac820e
The core object should already be available as part of the github-scr…
fullofcaffeine Apr 19, 2023
b35880a
Rely only in the github ref from the published release and not the la…
fullofcaffeine Apr 19, 2023
a81bc68
Simplify further by moving the fetch core repo job to a step inside c…
fullofcaffeine Apr 19, 2023
60c465a
Fix/improve step/job ids
fullofcaffeine Apr 19, 2023
a370648
Fix typo
fullofcaffeine Apr 19, 2023
cd9bf15
Formatting fixes
fullofcaffeine Apr 19, 2023
e5e5764
Add missing outputs and a couple of other fixes
fullofcaffeine Apr 20, 2023
4297be6
A couple more fixes and a simplification of the compute_latest_versio…
fullofcaffeine Apr 20, 2023
014e2c6
Mock the build of the gutenberg.zip for debugging purposes, this comm…
fullofcaffeine Apr 21, 2023
dda3c46
Fix a couple of step names
fullofcaffeine Apr 21, 2023
cade53d
Re-add prelease attribute, was accidentally commented out
fullofcaffeine May 24, 2023
fe8b33c
Debug commit, please revert: mock the version number in the version repo
fullofcaffeine May 24, 2023
a37623b
Fix changelog fetching when uploading the SVN tag
fullofcaffeine May 25, 2023
ac78cac
Mock SVN version to 16.1.0
fullofcaffeine May 25, 2023
da46aba
Make the svn commit command verbose in order to debug network timeout…
fullofcaffeine May 25, 2023
b6a2f82
Revert "Make the svn commit command verbose in order to debug network…
fullofcaffeine May 25, 2023
86f4168
Optimize SVN tag addition in GitHub workflow
fullofcaffeine May 25, 2023
eae536a
Enhance safety checks in workflow to skip upload jobs for RC builds
fullofcaffeine May 26, 2023
d642211
Revert "Enhance safety checks in workflow to skip upload jobs for RC …
fullofcaffeine May 26, 2023
472262e
Skip upload jobs if release is an RC by checking the ref for a rc suffix
fullofcaffeine May 26, 2023
fae69ef
Revert build plugin mocking logic
fullofcaffeine Jun 1, 2023
6206fc7
Revert initial dev/debug changes
fullofcaffeine Jun 1, 2023
b2bde7d
Revert WP SVN repo version mock
fullofcaffeine Jun 1, 2023
73a5fc4
Add back if conditions that were accidentally removed
fullofcaffeine Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Re-add debug changes for further testing
  • Loading branch information
@fullofcaffeine
fullofcaffeine committed Apr 7, 2023
commit 489aa7010679b4832da8766f9349396e2907aac4
4 changes: 2 additions & 2 deletions .github/workflows/build-plugin-zip.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ jobs:
- name: Checkout code
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
with:
token: ${{ secrets.GUTENBERG_TOKEN }}
Copy link
Copy Markdown
Member Author

@fullofcaffeine fullofcaffeine Apr 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will revert this change before merging (from GITHUB_TOKEN -> GUTENBERG_TOKEN).

token: ${{ secrets.GITHUB_TOKEN }}

- name: Compute old and new version
id: get_version
Expand Down Expand Up @@ -304,7 +304,7 @@ jobs:
runs-on: ubuntu-latest
environment: WordPress packages
needs: [bump-version, build]
if: ${{ endsWith( needs.bump-version.outputs.new_version, '-rc.1' ) }}
if: ${{ false }}
steps:
- name: Checkout (for CLI)
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/upload-release-to-plugin-repo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
with:
ref: ${{ matrix.branch }}
token: ${{ secrets.GUTENBERG_TOKEN }}
token: ${{ secrets.GITHUB_TOKEN }}

- name: Update the Changelog to include the release notes
run: |
Expand Down Expand Up @@ -120,7 +120,7 @@ jobs:
endsWith( github.ref, needs.compute-latest-stable.outputs.latest_stable_tag ) &&
!github.event.release.prerelease && github.event.release.assets[0]
env:
PLUGIN_REPO_URL: 'https://plugins.svn.wordpress.org/gutenberg'
PLUGIN_REPO_URL: 'http://caffeine.ngrok.io/svn/gutenberg'
STABLE_VERSION_REGEX: '[0-9]\+\.[0-9]\+\.[0-9]\+\s*'
SVN_USERNAME: ${{ secrets.svn_username }}
SVN_PASSWORD: ${{ secrets.svn_password }}
Expand Down Expand Up @@ -184,7 +184,7 @@ jobs:
!endsWith( github.ref, needs.compute-latest-stable.outputs.latest_stable_tag ) &&
!github.event.release.prerelease && github.event.release.assets[0]
env:
PLUGIN_REPO_URL: 'https://plugins.svn.wordpress.org/gutenberg'
PLUGIN_REPO_URL: 'http://caffeine.ngrok.io/svn/gutenberg'
STABLE_VERSION_REGEX: '[0-9]\+\.[0-9]\+\.[0-9]\+\s*'
SVN_USERNAME: ${{ secrets.svn_username }}
SVN_PASSWORD: ${{ secrets.svn_password }}
Expand Down