Conversation
|
Size Change: +93 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
ciampo
reviewed
Mar 15, 2023
ciampo
approved these changes
Mar 15, 2023
| */ | ||
| export default createHigherOrderComponent( ( OriginalComponent ) => { | ||
| function Component( | ||
| props: { [ key: string ]: any }, |
Contributor
There was a problem hiding this comment.
Not necessarily for this PR, but we should find a way for consumers of this HOC to get type checks on these props (ie. if they are compatible with OriginalComponent's prop types)
Member
Author
There was a problem hiding this comment.
Yes, I believe this will require TS changes in the createHigherOrderComponent function so the return function can take a generic argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #35744
What?
Convert the
withNoticesHOC to TypeScript.Testing Instructions
✅ Static checks pass