ImageSizeControl: Use large 40px sizes#49113
Merged
Conversation
richtabor
added
[Type] Enhancement
|
Size Change: +14 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 424cc0c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4472666984
|
jasmussen
approved these changes
Mar 16, 2023
Contributor
jasmussen
left a comment
jasmussen
left a comment
There was a problem hiding this comment.
Yep, let's do it.
In your recent slew of excellent PRs, was there one that added the help text below this selector?
mirka
approved these changes
Mar 16, 2023
Member
mirka
left a comment
mirka
left a comment
There was a problem hiding this comment.
Other than the rogue prop on Button, this looks good to me as well 🚀
packages/block-editor/src/components/image-size-control/index.js
Outdated
Show resolved
Hide resolved
richtabor
requested review from
ajitbohra,
nerrad,
noahtallen,
ntwb,
spacedmonkey and
tellthemachines
as code owners
Mamaduka
force-pushed
the
enhance/image-size-40
branch
from
e3ed16b to
424cc0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Updates the
SelectControlandNumberControlcomponents withinImageSizeControlto use the larger sizes.Why?
Supporting #46734.
Testing Instructions
Screenshots
Before:
After:
Notes
The 25/50/75/100/Reset buttons are omitted intentionally (#48618 (comment)).