Skip to content

List View: add an indicator of when a position type is set for a block #49122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewserong merged 10 commits into from
Jun 19, 2023
Merged

List View: add an indicator of when a position type is set for a block #49122

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
55e6d43
List View: add a position label when a position type is set for a block
andrewserong Mar 16, 2023
4340805
Move get label function to the useBlockDisplayInformation file
andrewserong Mar 16, 2023
3f31f9b
Try using icon over the block icon instead of a text label to indicat…
andrewserong Mar 20, 2023
d2e3aa7
Try more subtle icon / styling idea, and add in a tooltip
andrewserong Mar 22, 2023
f854ccd
Try provided svg icons
andrewserong Mar 23, 2023
1cd0e32
Don't change color when hovered
andrewserong Mar 23, 2023
b2b3997
Try separate sticky icon instead
andrewserong Jun 15, 2023
23bed70
Add pinSmall icon
andrewserong Jun 16, 2023
f6b6f14
Minify pinSmall
jameskoster Jun 16, 2023
aecbf4f
Add additional optional chaining because attributes can technically b…
andrewserong Jun 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't change color when hovered
  • Loading branch information
@andrewserong
andrewserong committed Jun 1, 2023
commit 1cd0e32ccca7befaa3d5cf1eb025f8e358d9bf07
5 changes: 3 additions & 2 deletions packages/block-editor/src/components/list-view/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,10 +309,11 @@
left: 0;
width: 24px;
height: 24px;
color: $gray-400;
}

&:not(.is-selected):not(:hover) .block-editor-list-view-block-select-button__sticky-indicator {
color: $gray-400;
&.is-selected .block-editor-list-view-block-select-button__sticky-indicator {
color: $white;
}

.block-editor-list-view-block-select-button__label-wrapper {
Expand Down