Skip to content

[RNMobile] Prevent blocks being un-wantingly replaced with newly added blocks #49154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SiobhyB merged 3 commits into from
Mar 17, 2023
Merged

[RNMobile] Prevent blocks being un-wantingly replaced with newly added blocks #49154

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d76d917
fix: Ensure bool acts the same for all OS versions
SiobhyB Mar 17, 2023
b6edf2b
fix: Revert previous dictation fix
SiobhyB Mar 17, 2023
2f6408f
fix: Revert previous dictation fix
SiobhyB Mar 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 4 additions & 14 deletions packages/react-native-aztec/ios/RNTAztecView/RCTAztecView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,13 +100,7 @@ class RCTAztecView: Aztec.TextView {
/// the dictation engine refreshes the TextView with an empty string when the dictation finishes.
/// This helps to avoid propagating that unwanted empty string to RN. (Solving #606)
/// on `textViewDidChange` and `textViewDidChangeSelection`
private var isInsertingDictationResult: Bool = {
if #available(iOS 16, *) {
return true;
} else {
return false;
}
}()
private var isInsertingDictationResult = false

// MARK: - Font

Expand Down Expand Up @@ -364,14 +358,10 @@ class RCTAztecView: Aztec.TextView {
}

public override func insertDictationResult(_ dictationResult: [UIDictationPhrase]) {
let objectPlaceholder = "\u{FFFC}"
let dictationText = dictationResult.reduce("") { $0 + $1.text }
if #available(iOS 16, *) {
insertText(dictationText)
} else {
let objectPlaceholder = "\u{FFFC}"
isInsertingDictationResult = false
self.text = self.text?.replacingOccurrences(of: objectPlaceholder, with: dictationText)
}
isInsertingDictationResult = false
self.text = self.text?.replacingOccurrences(of: objectPlaceholder, with: dictationText)
}

// MARK: - Custom Edit Intercepts
Expand Down