-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Theme JSON schema: Add defaultPresets property to shadow #49204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I have found that a similar schema fix was backported to wp/6.2 branch in #48948. I don't know if it is possible to backport it now, but I will give it a backport label just in case. |
|
Flaky tests detected in 793daa7. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4468654202
|
ajlende
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I found where shadow.defaultPresets is used.
And thanks for tightening up the additionalProperties for shadow. That's a good addition.
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: dcfb709 |
Related to: #46813
What?
This PR adds the
defaultPresetsproperty to theshadowproperty of thetheme.jsonschema.Why?
The dev note on the shadow property does not mention
defaultPresets. However, I would expect this property to be controllable viatheme.json.How?
I have set
additionalPropertiestofalsein addition to adding theshadowproperty.Testing Instructions
Create a JSON file that references this PR with the
$schemaproperty:{ "$schema": "https://raw.githubusercontent.com/WordPress/gutenberg/fix/schema-for-shadow-defaultpresets/schemas/json/theme.json", "version": 2, "settings": { "shadow": { } } }shadowproperty, confirm thedefaultPresetsproperty is selectable.defaultPresetsandpresets.