Skip to content

Make grid layout Group variation an experiment. #49359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tellthemachines merged 2 commits into from
Mar 27, 2023
Merged

Make grid layout Group variation an experiment. #49359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
769d120
Make grid layout Group variation an experiment.
tellthemachines Mar 27, 2023
6d0d6e4
Update packages/block-library/src/group/variations.js
tellthemachines Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/experimental/editor-settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@ function gutenberg_enable_experiments() {
if ( $gutenberg_experiments && array_key_exists( 'gutenberg-color-randomizer', $gutenberg_experiments ) ) {
wp_add_inline_script( 'wp-block-editor', 'window.__experimentalEnableColorRandomizer = true', 'before' );
}
if ( $gutenberg_experiments && array_key_exists( 'gutenberg-group-grid-variation', $gutenberg_experiments ) ) {
wp_add_inline_script( 'wp-block-editor', 'window.__experimentalEnableGroupGridVariation = true', 'before' );
}
}

add_action( 'admin_init', 'gutenberg_enable_experiments' );
12 changes: 12 additions & 0 deletions lib/experiments-page.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,18 @@ function gutenberg_initialize_experiments_settings() {
)
);

add_settings_field(
'gutenberg-group-grid-variation',
__( 'Grid variation for Group block ', 'gutenberg' ),
'gutenberg_display_experiment_field',
'gutenberg-experiments',
'gutenberg_experiments_section',
array(
'label' => __( 'Test the Grid layout type as a new variation of Group block.', 'gutenberg' ),
'id' => 'gutenberg-group-grid-variation',
)
);

register_setting(
'gutenberg-experiments',
'gutenberg-experiments'
Expand Down
9 changes: 6 additions & 3 deletions packages/block-library/src/group/variations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,10 @@ const variations = [
blockAttributes.layout?.orientation === 'vertical',
icon: stack,
},
{
];

if ( window?.__experimentalEnableGroupGridVariation ) {
variations.push( {
name: 'group-grid',
title: __( 'Grid' ),
description: __( 'Arrange blocks in a grid.' ),
Expand All @@ -51,7 +54,7 @@ const variations = [
isActive: ( blockAttributes ) =>
blockAttributes.layout?.type === 'grid',
icon: grid,
},
];
} );
}

export default variations;