Layout: Fix unstableDisableLayoutClassNames in Group block #49385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Bug
|
Size Change: +3 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
tellthemachines
approved these changes
Mar 27, 2023
Contributor
tellthemachines
left a comment
tellthemachines
left a comment
There was a problem hiding this comment.
LGTM! Thanks for fixing this.
Contributor
Author
|
Thanks for the quick review! 🙇 |
andrewserong
deleted the
fix/unstable-disable-layout-classnames-in-group-block
branch
|
Flaky tests detected in 665f666. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4537466114
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I accidentally removed the line that prevents layout classnames from being applied to the group block's inner wrapper in classic themes, over in #49361.
This PR restores the line that was accidentally removed.
Why?
In #49361, I was intending to only update the
renderAppenderline and accidentally removed__unstableDisableLayoutClassNamesat the same time.How?
Re-instate the line, as it was before #49361 landed.
Testing Instructions
is-layout-constrainedis applied to thewp-block-group__inner-containerelement.Screenshots or screencast