Skip to content

Selectors API: Make duotone selectors fallback and be scoped #49423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronrobertshaw merged 33 commits into from
Mar 31, 2023
Merged

Selectors API: Make duotone selectors fallback and be scoped #49423

Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
7735980
Make duotone selectors fallback and be scoped
aaronrobertshaw Mar 29, 2023
0c52d64
Use whole selectors for duotone as well
oandregal Mar 29, 2023
02bfc17
Update the block-level duotone selector
oandregal Mar 29, 2023
e5ed227
Use existing function
oandregal Mar 29, 2023
e60c4b7
scope the selectors in the post editor
scruffian Mar 29, 2023
555f7d0
Duotone: do not scope twice
oandregal Mar 29, 2023
64a505a
Simplify __experimentalDuotone backwards compatibility
Mar 29, 2023
3cd86f0
Update the __experimentalDuotoen back compat to explicitly handle eac…
Mar 29, 2023
7d370c6
Simplify adding the filter class to the selectors
Mar 29, 2023
521db54
Refactor to handle __experimentalDuotone where it was previously handled
Mar 30, 2023
fc2f0c0
Remove some dead code that I missed
Mar 30, 2023
53410e5
Fix lint
Mar 30, 2023
42e1b3f
Remove __experimentalDuotone test since it doesn't handle that anymore
Mar 30, 2023
50997ca
Remove remainder of duotone tests because it is no longer handled dif…
Mar 30, 2023
b9d16ea
Fix getBlockSelectors test because __experimentalDuotone now always r…
Mar 30, 2023
31aa06e
Fix rendering when preset doesn't exist
Mar 30, 2023
114ec2b
Fix unset filters
Mar 30, 2023
da60b58
Fix typos
aaronrobertshaw Mar 30, 2023
6a750e3
Update docs
aaronrobertshaw Mar 30, 2023
2236ce5
Tweak incorrect comment
aaronrobertshaw Mar 30, 2023
972dca7
Fix duotone support flag relocation
aaronrobertshaw Mar 30, 2023
b401c12
Add filter.duotone to block-supports docs
aaronrobertshaw Mar 30, 2023
59b135e
Add filter.duotone to block.json schema
aaronrobertshaw Mar 30, 2023
6367140
Be more precise in filterId selector comment
Mar 30, 2023
f1506d0
Fix filters in editor applying to cover block text
Mar 30, 2023
502f8b4
Remove comment I accidentally committed
Mar 30, 2023
571681e
Remove __experimentalDuotone from color supports docs
Mar 30, 2023
5f16e9c
Add example to the filter.duotone docs
Mar 30, 2023
bd02cb2
Move migration into duotone class
Mar 30, 2023
b20c08e
Add deprecation note to experimentalDuotone docs
Mar 30, 2023
a7337a7
Fix PHP lint
Mar 30, 2023
7e7bf1c
Fix PHP lint
Mar 30, 2023
3346b9a
Correct experimental BC comments and tweak flow
aaronrobertshaw Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove __experimentalDuotone from color supports docs
  • Loading branch information
Alex Lende committed Mar 30, 2023
commit 571681e88783ac1cb46d684b48a31fbe31f38d96
1 change: 0 additions & 1 deletion docs/reference-guides/block-api/block-supports.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,6 @@ supports: {
- Default value: null
- Subproperties:
- `background`: type `boolean`, default value `true`
- `__experimentalDuotone`: type `string`, default value undefined
- `gradients`: type `boolean`, default value `false`
- `link`: type `boolean`, default value `false`
- `text`: type `boolean`, default value `true`
Expand Down