-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Add new experimental version of DropdownMenu #49473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
9844c50
Add Radix deps
ciampo 0e79741
Re-export radix dropdown with some custom styles
ciampo 9b4c171
Add sample story
ciampo dc33f98
Start aggregating some components
ciampo 786acc5
Improve storybook config
ciampo 1ccabba
Use better colors
ciampo d29919a
Fix styles
ciampo 37eb61f
Move types to external file
ciampo 37582a2
Namespace all styled radix components under "DropdownMenuStyled" name…
ciampo ddda5c1
Use dot icon for radio items instead of check icon
ciampo 4b446db
Pass portal props to portal
ciampo 7a687ef
Add DropdownSubMenu component
ciampo 377c61c
Improve stories to use high-level components
ciampo c3d36c7
Update notes
ciampo 76ffab2
Comment out unused import
ciampo 0a3acf8
Use menu groups
ciampo 6665504
draft section in contributing guidelines
ciampo e93beff
Use wordpress icons instead of `@radix-ui/react-icons`
ciampo 6437b35
Add custom `icon` prop to `DropdownMenuItem`
ciampo 557b955
Add missing alignment property for sub trigger
ciampo 76ffa6b
Extract animation variables
ciampo a1318bf
Align colors more closely to WordPress styles
ciampo 4e32846
Add border to dropdown container
ciampo 4d15f22
Increase spacing, use `space` util
ciampo 76682ec
Use font utils
ciampo d637c50
Add focus-visible outline
ciampo 7c4769a
Alternative styling for submenu triggers
ciampo ae83a5e
Pick only selected props for DropdownMenu
ciampo 6dfa27d
Rewrite Storybook example to support controls
ciampo f376229
DropdownMenuItem: Pick only selected props, support prefix/suffix
ciampo 8f666b1
Remove forwarded refs
ciampo 1574406
Playing around with asChild and ref forwarding
ciampo b30c4c8
Updated remaining props
ciampo c41f58a
Add suffix to checkbox / radio items
ciampo 77585cd
Tweak styles (remove arrow, box shadow, center Storybook example)
ciampo 8dedbc1
Try separate submenu trigger component
mirka a8c66e1
Move layout wrapper to decorator
ciampo c6a1c40
Do not use `asChild` for indicator wrappers
ciampo d4b9add
Remove solved TODOs
ciampo a143f60
RTL support
ciampo a6bc304
Add support for reduced motion
ciampo a4b27b4
Expose component via lock APIs
ciampo d8518c0
Polish styles
ciampo c96e449
Generalize storybook
ciampo 0c6bce7
Focus/hover styles
ciampo 203b6a9
Refine styles
ciampo 2bf3379
Tweak storybook example (move separators out of groups, better item t…
ciampo 6a7ff14
Add unit tests
ciampo 82b526a
Move legacy implementation to v1 subfolder, move new implementation t…
ciampo 20552e7
READMEs
ciampo ce4d5c5
Tidy up types and JSDocs
ciampo f478db2
CHANGELOG
ciampo 01224d2
Update Storybook example title
ciampo b2ffd25
Fix imports
ciampo 1700cf3
Fix storybook path
ciampo 1f0b1b8
Fix test import path
ciampo 1233d26
Fix manifest.json
ciampo 5768fe7
Move legacy files back to where they were, v2 to separate dropdown-me…
ciampo 3c31da7
Update CHANGELOG and fix formatting
ciampo 01e990c
Use WP Button instead of custom button
ciampo ce296c2
Remove unnecessary decorator with shared context, using private state…
ciampo c9a7826
Remove opinionated wrapper centering styles
ciampo ddc1aa8
Update READMEs: remove v1, add experimental callout
ciampo da89425
Fix OG DropdownMenu import syntax to be consistent with TypeScript im…
ciampo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Tidy up types and JSDocs
- Loading branch information
commit ce4d5c54f7122715c35e0bc94eff556bb48fbc6b
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.