Skip to content

Group duotone outputs and refactor rendering #49705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajlende merged 4 commits into from
Apr 18, 2023
Merged

Group duotone outputs and refactor rendering #49705

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3253af8
Deprecate gutenberg_get_duotone_filter_id and gutenberg_get_duotone_f…
Apr 6, 2023
c2458ea
Refactor to group all duotone outputs
Apr 11, 2023
837f207
Deprecate unused public methods
Apr 11, 2023
ad8f98c
Add checks for other code generation output
Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Deprecate unused public methods
  • Loading branch information
@scruffian
Alex Lende authored and scruffian committed Apr 18, 2023
commit 837f207e86cb0bfec9cd6f58089bcb0b776bbbb6
21 changes: 21 additions & 0 deletions lib/class-wp-duotone-gutenberg.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -971,10 +971,17 @@ public static function migrate_experimental_duotone_support_flag( $settings, $me
/**
* Returns the prefixed id for the duotone filter for use as a CSS id.
*
* Exported for the deprecated function gutenberg_get_duotone_filter_id().
*
* @since 6.3.0
* @deprecated 6.3.0
*
* @param array $preset Duotone preset value as seen in theme.json.
* @return string Duotone filter CSS id.
*/
public static function get_filter_id_from_preset( $preset ) {
_deprecated_function( __FUNCTION__, '6.3.0' );

$filter_id = '';
if ( isset( $preset['slug'] ) ) {
$filter_id = self::get_filter_id( $preset['slug'] );
Expand All @@ -985,21 +992,35 @@ public static function get_filter_id_from_preset( $preset ) {
/**
* Gets the SVG for the duotone filter definition from a preset.
*
* Exported for the deprecated function gutenberg_get_duotone_filter_property().
*
* @since 6.3.0
* @deprecated 6.3.0
*
* @param array $preset The duotone preset.
* @return string The SVG for the filter definition.
*/
public static function get_filter_svg_from_preset( $preset ) {
_deprecated_function( __FUNCTION__, '6.3.0' );

$filter_id = self::get_filter_id_from_preset( $preset );
return self::get_filter_svg( $filter_id, $preset['colors'] );
}

/**
* Gets the CSS filter property value from a preset.
*
* Exported for the deprecated function gutenberg_get_duotone_filter_id().
*
* @since 6.3.0
* @deprecated 6.3.0
*
* @param array $preset The duotone preset.
* @return string The CSS filter property value.
*/
public static function get_filter_css_property_value_from_preset( $preset ) {
_deprecated_function( __FUNCTION__, '6.3.0' );

if ( isset( $preset['colors'] ) && is_string( $preset['colors'] ) ) {
return $preset['colors'];
}
Expand Down