-
Notifications
You must be signed in to change notification settings - Fork 4.7k
List View: Allow dragging to all levels of the block hierarchy #49742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
andrewserong
merged 11 commits into
trunk
from
update/list-view-to-allow-drag-at-all-levels-of-block-hierarchy
May 2, 2023
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
726fadb
List View: Allow drag to all levels of the block hierarchy
andrewserong 332f754
Allow drag to root
andrewserong 39d18c9
Partially fix block index for root blocks
andrewserong 752bd70
Attempt to fix blockIndex value and accounting for the dragged blocks
andrewserong ea625d6
Rearrange things slightly, tidy up comments
andrewserong b444cc0
Remove no longer needed comment
andrewserong d7cab3c
Update tests
andrewserong 41a1f9c
Add data-level to fix issue in Firefox
andrewserong ca8ec6d
Add missing comment
andrewserong 5e9068c
Add comments to link hard-coded indentation level and CSS
andrewserong 0e90f5d
Switch to getting aria-level by attribute instead of adding an extra …
andrewserong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add missing comment
- Loading branch information
commit ca8ec6d55b11ebf05df39e1ac662415cdce9209a
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have nice doc comments on all the functions except this one. Makes me feel bad for it 🥹
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was determined to make sure these were all documented, so thanks for flagging that one, it did look lonely! Updated in ca8ec6d