Merged
Conversation
jameskoster
added
Needs Design Feedback
|
Size Change: -239 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
Member
|
It does feel a bit much, especially in contrast with other UI radii—though it could be that I'm so used to the current value.
|
Member
|
I think
|
jasmussen
approved these changes
Apr 18, 2023
Contributor
jasmussen
left a comment
jasmussen
left a comment
There was a problem hiding this comment.
This is a good one: it makes the radius match that of the site view preview frame. It also well contains 2px buttons inside, and it feels useful for the larger command panel input field. Let's try it.
Before you land this, though, I'm pretty sure we need a changelog entry in packages/components/CHANGELOG.md.
| background: $white; | ||
| box-shadow: $shadow-modal; | ||
| border-radius: $radius-block-ui; | ||
| border-radius: $grid-unit; |
Contributor
There was a problem hiding this comment.
Should probably be $grid-unit-10 for accuracy, right? This will work, but I see the $grid-unit mostly as the base grid lacking a multiplication factor. I know that's nitpicky!
jameskoster
added
the
Design System
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Increase the base radius of modals in Gutenberg.
Why?
Modal radius came up as a detail to explore holistically in #49681. The current 2px value feels a bit sharp when compared to some newer UI elements such as the Frame in site view.
How?
Adjusts the CSS.
Testing Instructions
Try all the different modals to get a feel for the new, more rounded corners. Examples include: