Skip to content

Behaviors UI #49972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michalczaplinski merged 61 commits into from
May 24, 2023
Merged

Behaviors UI #49972

Changes from 1 commit
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
bd53de2
Add behaviors to the core theme.json
michalczaplinski Apr 21, 2023
bd43bf6
Add behaviors to json schemas for theme.json
michalczaplinski Apr 21, 2023
e1dd737
Add a behaviors panel
michalczaplinski May 3, 2023
8b84a22
Remove the changes to theme.json schema
michalczaplinski May 5, 2023
d5dbc1c
Add behaviors to the VALID_SETTINGS in class-wp-theme-json-gutenberg.php
michalczaplinski May 5, 2023
037d669
Add the first (still broken) version of the lightbox settings
michalczaplinski May 5, 2023
8f62d34
WIP: Added a SelectControl for the behaviors
michalczaplinski May 9, 2023
62b6217
Format PHP
michalczaplinski May 9, 2023
edfd7d1
Format correctly again
michalczaplinski May 9, 2023
8ee4065
Use the props.name when getting the behaviors
michalczaplinski May 10, 2023
594224b
Add initial e2e tests
cbravobernal May 10, 2023
fd6fe36
Update the withBehaviors description
michalczaplinski May 10, 2023
da4a5ad
Cleaned up behaviors.js
michalczaplinski May 11, 2023
2958fd1
Update e2e tests to check visibility
cbravobernal May 12, 2023
0a68bea
Update core-blocks doc with behaviors attribute
cbravobernal May 12, 2023
fd08928
Update fixtures with new lightbox attribute
cbravobernal May 13, 2023
4e03e0d
Add a new theme for e2e tests
michalczaplinski May 16, 2023
92b6e6c
Change theme.json to include `settings.behaviors`
michalczaplinski May 16, 2023
ffa881e
Remove default behavior value from block.json
michalczaplinski May 16, 2023
99c964b
Minor fix to the implementation
michalczaplinski May 16, 2023
7f7db2c
Add more e2e tests
michalczaplinski May 16, 2023
5e5ff9a
Create a selector for behaviors
michalczaplinski May 17, 2023
ad20b64
Add a filter to load behaviors on the server from the theme.json
michalczaplinski May 17, 2023
d16266b
Add behaviors on the top-level in core theme.json
michalczaplinski May 17, 2023
0982d9f
Use the behaviors in the hooks
michalczaplinski May 17, 2023
0ef7b5e
Update the comment
michalczaplinski May 17, 2023
e75fd87
Update the comment in behaviors.js
michalczaplinski May 17, 2023
f6414f9
Update fixtures and e2e
cbravobernal May 17, 2023
31c0623
Prevent mobile test gutenberg error (temporary - not the best solution)
cbravobernal May 18, 2023
ee3701f
Add priority on filter
cbravobernal May 18, 2023
a0ac748
Fix php standards
cbravobernal May 18, 2023
1dd6df1
Found a much better way to fix php tests
cbravobernal May 18, 2023
a737200
Small refactor
cbravobernal May 18, 2023
3fd9270
Add `behaviors` as an allowed key to BLOCK_EDITOR_SETTINGS
michalczaplinski May 18, 2023
5a9748c
Move the behaviors to top level in the e2e test theme.json file
michalczaplinski May 18, 2023
9a6b1f2
Rename the `behaviors` setting to `behaviorsUIEnabled`
michalczaplinski May 18, 2023
1c7f6d5
Change "None" to "No behaviors"
michalczaplinski May 18, 2023
470f74f
Behaviors -> behavior
michalczaplinski May 18, 2023
bba7c2d
Fix redundant ternary
michalczaplinski May 18, 2023
2cb348c
Improve the JSDoc for behaviors selector
michalczaplinski May 18, 2023
c65bc57
Rename the test themes to make more sense
michalczaplinski May 19, 2023
1c655f7
Remove definition of `behaviors` attribute in core/image
michalczaplinski May 22, 2023
697c04f
Change default value for `behaviors.lightbox` to false and update e2e…
michalczaplinski May 22, 2023
d4fd9d9
Change the way we get the data from `theme.json` and adjust e2e
michalczaplinski May 23, 2023
a57d634
Capitalize behaviors' labels
michalczaplinski May 23, 2023
234a8b6
Move PHP code adding `theme.json` behaviors to `block-editor-settings`
michalczaplinski May 23, 2023
4bef633
Update comment
michalczaplinski May 23, 2023
7aa7231
Remove the behaviors require from load.php
michalczaplinski May 23, 2023
1d923ab
Revert "Update comment"
michalczaplinski May 23, 2023
aee908a
Revert "Move PHP code adding `theme.json` behaviors to `block-editor-…
michalczaplinski May 23, 2023
33cb62d
Remove the comment that was added previously
michalczaplinski May 23, 2023
55e37a3
Update comments in `behaviors.php`
michalczaplinski May 23, 2023
d4d657b
Add back the require_once in load.php
michalczaplinski May 23, 2023
8d6b0d0
Use `settings.blocks.core/image.behaviors.lightbox`
michalczaplinski May 23, 2023
76b2a75
Use `behaviors.blocks.core/image.lightbox`
michalczaplinski May 23, 2023
70e51cd
Remove experimental setting for interactivity API
cbravobernal May 24, 2023
69ebe6c
Revert "Remove experimental setting for interactivity API"
cbravobernal May 24, 2023
c32be86
Move `interactivity.js` files to `block.json`
SantosGuillamot May 24, 2023
b8dc7dd
Remove experimental flag for the Interactivity API
SantosGuillamot May 24, 2023
4800d91
Revert "Move `interactivity.js` files to `block.json`"
michalczaplinski May 24, 2023
9124b58
Revert "Remove experimental flag for the Interactivity API"
michalczaplinski May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add behaviors on the top-level in core theme.json
  • Loading branch information
@michalczaplinski @cbravobernal
michalczaplinski authored and cbravobernal committed May 23, 2023
commit d16266b4f5ad3c827e669c3c3b4899f6303abaf7
6 changes: 3 additions & 3 deletions lib/theme.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"version": 2,
"behaviors": {
"lightbox": true
},
"settings": {
"behaviors": {
"lightbox": true
},
"appearanceTools": false,
"useRootPaddingAwareAlignments": false,
"border": {
Expand Down