Skip to content

Global Styles: Fix palette color popovers #49975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronrobertshaw merged 10 commits into from
May 4, 2023
Merged

Global Styles: Fix palette color popovers #49975

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cfd4163
Allow passing popover props for palette popovers
aaronrobertshaw Apr 21, 2023
cd394ff
Leverage popover props to modify palette popovers on mobile
aaronrobertshaw Apr 21, 2023
b554e20
Add changelog
aaronrobertshaw Apr 24, 2023
384bf31
Tweak PaletteEdit storybook default args for popover position
aaronrobertshaw Apr 24, 2023
c70716b
Improve changelog description
aaronrobertshaw Apr 24, 2023
31f2f94
Clean up types
aaronrobertshaw May 2, 2023
2b5b2ec
Prevent color palette panel recreating popoverProps
aaronrobertshaw May 2, 2023
2db40ff
Make memoization consistent and merge classnames
aaronrobertshaw May 2, 2023
1f6490c
Tweak popoverProps type
aaronrobertshaw May 4, 2023
fd815ed
Fix changelog
aaronrobertshaw May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Tweak popoverProps type
  • Loading branch information
@aaronrobertshaw
aaronrobertshaw committed May 4, 2023
commit 1f6490cada282538962bd760d2943d93e2b9ce45
5 changes: 2 additions & 3 deletions packages/components/src/palette-edit/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@ import type { Key, MouseEventHandler } from 'react';
/**
* Internal dependencies
*/
import type Popover from '../popover';
import type { HeadingSize } from '../heading/types';
import type { PopoverProps } from '../popover/types';
import type { WordPressComponentProps } from '../ui/context';

export type Color = {
color: string;
Expand Down Expand Up @@ -64,7 +63,7 @@ export type BasePaletteEdit = {
* Props to pass through to the underlying Popover component.
*/
popoverProps?: Omit<
WordPressComponentProps< PopoverProps, 'div', false >,
React.ComponentPropsWithoutRef< typeof Popover >,
'children'
>;
};
Expand Down