Assign control isActive as boolean #500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously as function invoked immediately anyways
aduth
added
the
Framework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously: #460 (comment)
This pull request seeks to change the behavior of the
<Toolbar />component'scontrol.isActivefrom a function to plain boolean. Since it's currently never the case that we need to asynchronously determine the active value, there's no real need for it to be treated as a callback.Testing instructions:
Verify that button active (selected) states behave as expected, between both the block controls (e.g. text alignment) and formatting controls (e.g. bold, italic, see #460).