TreeGrid: Update README with data-expanded attribute usage#50026
Merged
TreeGrid: Update README with data-expanded attribute usage#50026
Conversation
alexstine
added
[Focus] Accessibility (a11y)
ciampo
approved these changes
Apr 27, 2023
Contributor
ciampo
left a comment
ciampo
left a comment
There was a problem hiding this comment.
Thank you @alexstine for following up on this!
I went ahead and added a couple of commits, adding a CHANGELOG entry for the @wordpress/components package and copying the same paragraph that you added to the README in the types.ts file, so that it will also show in the TypeScript JSDocs.
LGTM 🚀
ciampo
force-pushed
the
update/tree-grid-readme-a11y
branch
from
db672c5 to
4d01afb
Compare
|
Flaky tests detected in 4d01afb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4824052490
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Updates the README for the TreeGrid component with a new
data-expandedusage example.Why?
Docs are important.
How?
Make the edits.
Testing Instructions
N/A.
Testing Instructions for Keyboard
N/A.
Screenshots or screencast