Fix BlockInfo slot displaying logic #50054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
ntsekouras
requested review from
Mamaduka,
aaronrobertshaw,
jasmussen and
talldan
jasmussen
approved these changes
Apr 25, 2023
Contributor
jasmussen
left a comment
jasmussen
left a comment
There was a problem hiding this comment.
Seems to behave correctly now, showing the "Add new post" only on the query loop:
Mamaduka
approved these changes
Apr 25, 2023
Member
Mamaduka
left a comment
Mamaduka
left a comment
There was a problem hiding this comment.
Nice catch, Nik!
The fix works as expected!
|
Size Change: +7 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
Contributor
|
Thank you for the fix and clean up @ntsekouras 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow up of: #49819
In the above PR a new private BlockInfo slot was introduced but the conditional display of it's contents was missed. The result was the
add new postlink to be shown in every block:This PR adds the conditional display logic and also removes some related leftovers that weren't used right now.
Testing Instructions
add new postlink is added only in Query Loop and when is selected.