Data: Expose registered selectors as functions #5007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
Framework
Member
Author
|
Added upgrade path for deprecated usage in 338e5a8. |
Member
|
This is how I always wanted to have it shaped 💯 |
mcsf
approved these changes
Feb 12, 2018
Contributor
mcsf
left a comment
mcsf
left a comment
There was a problem hiding this comment.
A worthwhile change for me. 👌
youknowriad
reviewed
Feb 13, 2018
| selectors[ reducerKey ] = newSelectors; | ||
| const store = stores[ reducerKey ]; | ||
| const createStateSelector = ( selector ) => ( ...args ) => selector( store.getState(), ...args ); | ||
| selectors[ reducerKey ] = mapValues( newSelectors, createStateSelector ); |
Contributor
There was a problem hiding this comment.
Initially, I wanted to avoid having to create a wrapper for each selector but I do see the DevX benefits from this new API
youknowriad
approved these changes
Feb 13, 2018
youknowriad
added
the
[Type] Breaking Change
gziolo
added
the
[Feature] Extensibility
3 tasks
aduth
removed
the
[Type] Breaking Change
aduth
force-pushed
the
update/data-bound-selectors
branch
2 times, most recently
from
e306914 to
08a47de
Compare
aduth
force-pushed
the
update/data-bound-selectors
branch
from
08a47de to
0cbecd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #4105
This pull request seeks to update the data module selector pattern to expose selectors as functions directly, not invoke via named string arguments.
Before:
After:
Implementation notes:
Since this was included in 2.1.0 of the plugin, do we need to include a deprecation upgrade path?Added in 338e5a8.Testing instructions:
Ensure unit tests pass:
Verify there are no regressions in the current usage of data module
select.