Skip to content

Show the content of the paragraph and list items in the list view. #50135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juanfra wants to merge 7 commits into
base: trunk
Choose a base branch
from
Open

Show the content of the paragraph and list items in the list view. #50135

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6a7b0fa
Show the content of the paragraph and list items in the list view.
juanfra Apr 27, 2023
01384ae
Merge branch 'master' into fix/42605-list-view
juanfra May 2, 2023
9f25f73
Merge branch 'master' into fix/42605-list-view
juanfra May 3, 2023
09992b4
Merge branch 'master' into fix/42605-list-view
juanfra Jun 5, 2023
507f5aa
Merge branch 'master' into fix/42605-list-view
juanfra Jun 16, 2023
6ef5e45
Merge branch 'master' into fix/42605-list-view
juanfra Aug 11, 2023
39a815a
Merge branch 'master' into fix/42605-list-view
juanfra Sep 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Show the content of the paragraph and list items in the list view.
  • Loading branch information
@juanfra
juanfra committed Apr 27, 2023
commit 6a7b0fa0ff9766a9cf1acebc88b8a0bfa7605b1c
9 changes: 9 additions & 0 deletions packages/block-library/src/list-item/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,15 @@ export const settings = {
};
},
transforms,
__experimentalLabel( attributes, { context } ) {
const { content } = attributes;

// In the list view, use the block's content as the label.
// If the content is empty, fall back to the default label.
if ( context === 'list-view' && content ) {
return content;
}
},
};

export const init = () => initBlock( { name, metadata, settings } );
9 changes: 8 additions & 1 deletion packages/block-library/src/paragraph/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,17 @@ export const settings = {
},
},
__experimentalLabel( attributes, { context } ) {
const { content } = attributes;

if ( context === 'accessibility' ) {
const { content } = attributes;
return ! content || content.length === 0 ? __( 'Empty' ) : content;
}

// In the list view, use the block's content as the label.
// If the content is empty, fall back to the default label.
if ( context === 'list-view' && content ) {
return content;
}
},
transforms,
deprecated,
Expand Down