Skip to content

List View: Allow right-click to open block settings dropdown, add editor setting #50273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewserong merged 5 commits into from
Dec 14, 2023
Merged

List View: Allow right-click to open block settings dropdown, add editor setting #50273

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
41d62f4
List View: Allow right-click to open block settings dropdown, add set…
andrewserong May 3, 2023
7c23264
Fix flicker of focus state when initially right clicking
andrewserong May 25, 2023
007a1ed
Tidy up useSelect
andrewserong Sep 14, 2023
35d42be
Fix e2e test (hopefully)
andrewserong Dec 14, 2023
4523767
Update help text for preferences items
andrewserong Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update help text for preferences items
  • Loading branch information
@andrewserong
andrewserong committed Dec 14, 2023
commit 452376760e91e594a877428b9de1a1b30e7c9e56
2 changes: 1 addition & 1 deletion packages/edit-post/src/components/preferences-modal/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ export default function EditPostPreferencesModal() {
<EnableFeature
featureName="allowRightClickOverrides"
help={ __(
'Allows contextual menus via right-click, overriding browser defaults.'
'Allows contextual list view menus via right-click, overriding browser defaults.'
) }
label={ __(
'Allow right-click contextual menus'
Expand Down
2 changes: 1 addition & 1 deletion packages/edit-site/src/components/preferences-modal/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export default function EditSitePreferencesModal() {
<EnableFeature
featureName="allowRightClickOverrides"
Copy link
Member

@ramonjd ramonjd Sep 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, enableListViewRightClick or allowListViewContextualMenus or the equivalent specific descriptor might describe the feature. allowRightClickOverrides might be too generic?

Copy link
Contributor Author

@andrewserong andrewserong Sep 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question! My thinking was to keep it generic so that if we wish to expand other areas to also have right click overrides, we don't wind up with a proliferation of allowRightClick settings in the preferences 🤔

help={ __(
'Allows contextual menus via right-click, overriding browser defaults.'
'Allows contextual list view menus via right-click, overriding browser defaults.'
) }
Copy link
Member

@ramonjd ramonjd Sep 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to communicate that it's specific to the List view here? I don't think it has effect anywhere else in the editor (?)

Copy link
Contributor Author

@andrewserong andrewserong Sep 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, for the user facing help text, that's a great idea! Perhaps Allows contextual list view menus via right-click... or something like that.

label={ __( 'Allow right-click contextual menus' ) }
/>
Expand Down