Skip to content

Conversation

@talldan
Copy link
Contributor

@talldan talldan commented May 5, 2023

What?

Fixes #50350
Similar to #45630

Updates the 'Tested up to' version for the plugin.

I think this is usually done after a WordPress release, but must have been forgotten.

@talldan talldan added the [Type] Task Issues or PRs that have been broken down into an individual action to take label May 5, 2023
@talldan talldan self-assigned this May 5, 2023
@talldan talldan added the Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts label May 5, 2023
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@talldan
Copy link
Contributor Author

talldan commented May 5, 2023

I may have to use my admin powers to merge this, as the 'Pull request automation' job doesn't like the fact that I left a reference to a discussion in the PR description. 😢

Even when I update the PR description and re-run the job it still fails.

edit: it wasn't a required check, so it was ok 😌

@talldan talldan merged commit 5f61472 into trunk May 5, 2023
@talldan talldan deleted the update/tested-version-for-plugin branch May 5, 2023 06:29
@github-actions github-actions bot added this to the Gutenberg 15.8 milestone May 5, 2023
@kgarrett67
Copy link

I was excited to see a new version of Gutenberg today, but my excitement left me when I discovered it too does not show compatibility with WordPress 6.2

gutenberg_1571

@talldan
Copy link
Contributor Author

talldan commented May 12, 2023

@kgarrett67 Version 15.8 will show compatibility with 6.2. Sorry, we probably should have tried to get this into 15.7!

@youknowriad
Copy link
Contributor

There's a subtlety here for the next updates that we make to this flag.

Basically this change triggers the "wordpress version" to change for the performance jobs, so we need to make sure to update the "commit hash" we use as a "comparison" basis when we do that to ensure that that "hash" is actually compatible with 6.2. The current hash is older than 6.2, so it might not be compatible and have the potential to create "wrong" numbers.

So ideally, we'd update that hash with the latests commit hash of the "wp/6.2" branch.

@oandregal mentioned to me that we could automate that commit hash and maybe automatically get the "hash" of the tag of the 6.2 version. (tested up to flag)

@oandregal
Copy link
Member

I pushed #51381 to update to the latest commit in the wp/6.2 branch. Thought of using the wp/6.2 branch name, but it's a moving target: the branch is updated for minor releases and security updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Task Issues or PRs that have been broken down into an individual action to take

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants