Skip to content

[ListView] Allow deleting blocks using keyboard #50422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevin940726 merged 5 commits into from
May 28, 2023
Merged

[ListView] Allow deleting blocks using keyboard #50422

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e0b8130
Allow deleting blocks using keyboard from listview
kevin940726 May 4, 2023
d793d18
Update updateSelection instead
kevin940726 May 10, 2023
9431f32
Add support for kyeboard shortcut in the dropdown
kevin940726 May 11, 2023
9354a81
Only select block if there isn't any already
kevin940726 May 11, 2023
4274a5e
More things!
kevin940726 May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Only select block if there isn't any already
  • Loading branch information
@kevin940726
kevin940726 committed May 27, 2023
commit 9354a81fcc72a5785f7aebb0e593d6e21a4c86a5
6 changes: 5 additions & 1 deletion packages/block-editor/src/components/list-view/block.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,11 @@ function ListViewBlock( {

const updateSelection = useCallback(
( newClientId ) => {
selectBlock( undefined, newClientId, null, null );
const selectedBlockClientIds = getSelectedBlockClientIds();
// Select the block to be focused if there isn't any block selected.
if ( ! selectedBlockClientIds.length ) {
selectBlock( undefined, newClientId, null, null );
}

const getFocusElement = () => {
const row = treeGridElementRef.current?.querySelector(
Expand Down