Skip to content

ColorPalette: Improve color name readability #50450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chad1008 merged 31 commits into from
May 31, 2023
Merged

ColorPalette: Improve color name readability #50450

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
8b5d427
Move color name and value below picker swatch
chad1008 May 8, 2023
40cf2b3
update component styles
chad1008 May 8, 2023
bd97be7
update CHANGELOG
chad1008 May 9, 2023
f1b8099
update snapshot
chad1008 May 9, 2023
f232053
update unit tests
chad1008 May 9, 2023
d981a96
simplify CSS
chad1008 May 10, 2023
639be04
simplify border styling
chad1008 May 10, 2023
ba7a5a8
replace `Flex` with `VStack`
chad1008 May 10, 2023
b2b05c4
remove `var()` wrapper from css vars
chad1008 May 10, 2023
d4880c5
re-update snapshot
chad1008 May 10, 2023
ffeddd5
display default text for no value
chad1008 May 15, 2023
a64ed18
implement proper BEM notation
chad1008 May 15, 2023
5d41512
update snapshot with BEM notation
chad1008 May 15, 2023
65caf90
Updating block editor snapshots again
chad1008 May 16, 2023
65c33fc
simplify `displayValue` declaration
chad1008 May 17, 2023
b032818
Remove extra curly braces
chad1008 May 17, 2023
1c6774a
Add layout comment
chad1008 May 17, 2023
43507c5
fix color value span min-height
chad1008 May 18, 2023
af8931f
Always show checkered background
chad1008 May 18, 2023
eab5fea
hyphenate hex codes for assistive tech
chad1008 May 22, 2023
300cbf0
snapshot updated to include hex code hyphens
chad1008 May 24, 2023
a674052
Update unit tests
chad1008 May 24, 2023
7e43311
remove hardcoded `px` value for `min-height`
chad1008 May 24, 2023
4e69db7
update snapshots yet again
chad1008 May 24, 2023
5fbb188
rename new test and expose onChange
chad1008 May 25, 2023
28a81df
apply unit test feedback
chad1008 May 25, 2023
59e9492
improve color value text contrast
chad1008 May 25, 2023
42683a8
Merge branch 'trunk' into colorpalette-layout-update
chad1008 May 25, 2023
7435f08
move CHANGELOG entry
chad1008 May 25, 2023
0823d7d
remove duplicate check for cleared color value text
chad1008 May 31, 2023
03140aa
merge `trunk` into `colorpalette-laytout-update`
chad1008 May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update snapshots yet again
  • Loading branch information
@chad1008
chad1008 committed May 24, 2023
commit 4e69db78cfe8024995a6957bf39f94c9a8674806
1 change: 0 additions & 1 deletion packages/block-editor/src/components/color-palette/test/__snapshots__/control.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,6 @@ exports[`ColorPaletteControl matches the snapshot 1`] = `
class="components-truncate components-color-palette__custom-color-value components-color-palette__custom-color-value--is-hex emotion-14 emotion-5"
data-wp-c16t="true"
data-wp-component="Truncate"
style="min-height: 18px;"
>
#f00
</span>
Expand Down
1 change: 0 additions & 1 deletion packages/components/src/color-palette/test/__snapshots__/index.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,6 @@ exports[`ColorPalette should render a dynamic toolbar of colors 1`] = `
class="components-truncate components-color-palette__custom-color-value components-color-palette__custom-color-value--is-hex emotion-6 emotion-1"
data-wp-c16t="true"
data-wp-component="Truncate"
style="min-height: 18px;"
>
#f00
</span>
Expand Down