Button: Update disabled state to be without background.#50496
Merged
Button: Update disabled state to be without background.#50496
Conversation
jasmussen
added
[Feature] UI Components
|
Size Change: +4.75 kB (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 63d9394. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4960497871
|
mirka
approved these changes
May 12, 2023
Member
mirka
left a comment
mirka
left a comment
There was a problem hiding this comment.
Looks good to me 👍 I just pushed some minor cleanup.
|
|
||
| &:active:not(:disabled) { | ||
| background: $components-color-gray-300; | ||
| color: $components-color-accent-darker-10; |
Member
There was a problem hiding this comment.
Not that I object but just checking since it wasn't mentioned in the PR description — is it intentional for the text to turn black when clicked?
CleanShot.2023-05-13.at.00.20.06.mp4
ciampo
reviewed
May 12, 2023
| &:disabled, | ||
| &[aria-disabled="true"], | ||
| &[aria-disabled="true"]:hover { | ||
| // TODO: Prepare for theming (https://github.com/WordPress/gutenberg/pull/45466/files#r1030872724) |
Contributor
There was a problem hiding this comment.
I think that this comment still applies, right? We should still think about adding variables at the theme level for disabled UI
Member
There was a problem hiding this comment.
The TODO comments were specifically for the issue of darken/lighten Sass functions being used on theme variables.
As for the theme-ready gray variables, we simply haven't put them to use anywhere yet. So I was kind of thinking of that as a big separate task rather than a contextual TODO item 😄
Contributor
Author
|
Thanks for all the help! I'm going to merge this one but always happy to follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
The disabled state of notably the tertiary variant of the button component adds a background:
This is incorrect for that particular variant, this PR removes it:
Incidentally that unifies its style with this "Saved" disabled button as well.
The PR also updates some incorrect hover and active states.
Why?
The primary button is filled, the secondary button is outlined, the tertiary button is without background. This makes that consistent for the disabled state.
Testing Instructions
Create a new post, and before adding any content, observe the save draft and preview buttons.