Skip to content

Add the ability to create a new page in the Site Editor #50565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SaxonF merged 23 commits into from
Jun 6, 2023
Merged

Add the ability to create a new page in the Site Editor #50565

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
b39b236
create new page
SaxonF May 12, 2023
f045425
remove pages nesting
SaxonF May 12, 2023
f3e097a
add redirectAfterSave to add page modal
SaxonF May 15, 2023
67c222f
reset redirectAfterSave
SaxonF May 15, 2023
216bb20
adjust copy of new page to show draft
SaxonF May 15, 2023
6558f3f
redirect after adding page
SaxonF May 16, 2023
5fc86cf
create page modal use local state
SaxonF May 17, 2023
205a2a6
fix import add page
SaxonF May 17, 2023
13c4eee
add page use onClose and remove setPage
SaxonF May 18, 2023
b4f4817
cleaning up add page
SaxonF May 18, 2023
7f0140e
Merge branch 'trunk' into add/add-new-page
SaxonF May 24, 2023
7ad5b2b
removed value and used placeholder for add page
SaxonF May 24, 2023
2148ede
add page modal translations
SaxonF May 26, 2023
e46efae
e2e test new page modal
SaxonF May 26, 2023
28d80f4
Merge branch 'trunk' into add/add-new-page
SaxonF May 26, 2023
79d1116
move setting current canvas
SaxonF May 29, 2023
604051c
removed unnecessary help text
SaxonF May 30, 2023
a2426d5
Revert "move setting current canvas"
SaxonF May 31, 2023
ef1c31c
Merge branch 'trunk' into add/add-new-page
SaxonF May 31, 2023
0f168d2
update add new page placeholder
SaxonF Jun 6, 2023
3edbff5
auto focus add new page input
SaxonF Jun 6, 2023
49635c0
Merge branch 'add/add-new-page' of https://github.com/WordPress/guten…
SaxonF Jun 6, 2023
0efe958
add no title placeholder
SaxonF Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
reset redirectAfterSave
  • Loading branch information
@SaxonF
SaxonF committed May 15, 2023
commit 67c222f283c892fde7e8d73da46535d568f1e977
2 changes: 1 addition & 1 deletion packages/edit-site/src/components/add-new-page/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ export default function AddNewPageModal() {
}

// Close the modal when complete
setIsCreatePageModalOpened( false );
setIsCreatePageModalOpened( false, { redirectAfterSave: false } );

Copy link
Contributor

@jeryj jeryj May 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the page is created, where should focus get placed? Right now it's being dropped at the hidden Back button in the closed sidebar. I agree with @carolinan that the current mode of being moved to the site editor template for this page is an odd experience. I'd be fine with it if the sidebar stayed open, in which case, handling the focus here isn't an issue since it's being placed in a sensible spot.

Copy link
Contributor Author

@SaxonF SaxonF May 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the current mode of being moved to the site editor template for this page is an odd experience

This will make more sense once the content editing PR is merged. There is also some follow up work around improving the add page experience, including selecting starter patterns.

createSuccessNotice(
sprintf(
Expand Down