Skip to content

Try adding dynamic page templates to pages section #50630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tellthemachines merged 15 commits into from
May 30, 2023
Merged

Try adding dynamic page templates to pages section #50630

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
bf2ec56
Try adding dynamic page templates to pages section
tellthemachines May 15, 2023
46e813e
remove recent heading in pages
SaxonF May 15, 2023
02ebcbe
Static homepage case
tellthemachines May 16, 2023
9c0099b
Back button should go back to Pages
tellthemachines May 16, 2023
1add381
Fix order of home and blog pages
tellthemachines May 16, 2023
75e287f
Try fetching all the pages
tellthemachines May 17, 2023
e8c6695
Stick templates to bottom
tellthemachines May 17, 2023
1631b32
Stick item positioning
jameskoster May 17, 2023
a107162
Revert custom back button behaviour
tellthemachines May 24, 2023
92ee8ab
Move manage link to dynamic pages group
jameskoster May 24, 2023
db06915
Remove home/posts page suffixes
jameskoster May 24, 2023
bb94a22
Address feedback
tellthemachines May 26, 2023
2ba722b
Add back truncation
tellthemachines May 29, 2023
a151d40
Copy array for reorder
tellthemachines May 29, 2023
9c218f6
Consolidate sticky styles
tellthemachines May 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Consolidate sticky styles
  • Loading branch information
@tellthemachines
tellthemachines committed May 29, 2023
commit 9c218f6961e0842f84026659cfd1f35ecf099ce6
5 changes: 0 additions & 5 deletions packages/edit-site/src/components/sidebar-navigation-screen-page/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
.edit-site-sidebar-navigation-screen__sticky-section {
padding: $grid-unit-40 0;
margin: $grid-unit-40 $grid-unit-20;
}

.edit-site-sidebar-navigation-screen-page__featured-image-wrapper {
background-color: $gray-800;
margin-bottom: $grid-unit-20;
Expand Down
9 changes: 0 additions & 9 deletions packages/edit-site/src/components/sidebar-navigation-screen-pages/style.scss
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions packages/edit-site/src/components/sidebar-navigation-screen/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,12 +73,12 @@
}
}

.edit-site-sidebar-navigation-screen__sticky-section {
.edit-site-sidebar-navigation-screen__sticky-section.edit-site-sidebar-navigation-screen__sticky-section {
position: sticky;
bottom: 0;
background-color: $gray-900;
gap: 0;
padding: $grid-unit-20 0;
margin: $grid-unit-20 0 #{- $grid-unit-20} 0;
padding: $grid-unit-40 0;
margin: $grid-unit-40 $grid-unit-20;
border-top: 1px solid $gray-800;
}
1 change: 0 additions & 1 deletion packages/edit-site/src/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
@import "./components/sidebar-button/style.scss";
@import "./components/sidebar-navigation-item/style.scss";
@import "./components/sidebar-navigation-screen/style.scss";
@import "./components/sidebar-navigation-screen-pages/style.scss";
@import "./components/sidebar-navigation-screen-page/style.scss";
@import "./components/sidebar-navigation-screen-template/style.scss";
@import "./components/sidebar-navigation-screen-templates/style.scss";
Expand Down