-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Playlist block #50664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
carolinan
wants to merge
127
commits into
trunk
Choose a base branch
from
try/playlist2
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Playlist block #50664
Changes from 1 commit
Commits
Show all changes
127 commits
Select commit
Hold shift + click to select a range
8b44789
Basic playlist block
carolinan 4198e21
try to make some accessibility improvements
carolinan ac17285
Park the PHP file until work can continue
carolinan 1fcbf71
Update index.php
carolinan 8aed3d3
Update index.php, try to solve merge conflicts
carolinan 14e1fa5
Remove the style variation
carolinan 92a3c65
Remove the unused save, add escaping, update css
carolinan 59bb48f
Update edit.js
carolinan 4ba31d9
Update edit.js
carolinan 1e94427
Update edit.js
carolinan 00d6970
Merge branch 'trunk' into try/playlist2
carolinan ca834be
fix CS issues
carolinan cce2cc5
Fix two issues with the upload option.
carolinan 54cc037
Disable uploading and selecting multiple files in the replacement flow.
carolinan 381650a
Update the placeholder instructions
carolinan ff810d2
Merge branch 'trunk' into try/playlist2
carolinan dab0e24
Correct a translators comment.
carolinan 04a8368
Hide tracklist options if the tracklist itself is toggled off
carolinan 19fc308
Merge branch 'trunk' into try/playlist2
carolinan 7358614
Merge branch 'trunk' into try/playlist2
carolinan 8bb139e
Merge branch 'trunk' into try/playlist2
carolinan 38eaeed
Merge branch 'trunk' into try/playlist2
carolinan d9ff601
Merge branch 'trunk' into try/playlist2
carolinan b59aba1
Try to fix CS issues, update to apiVersion 3
carolinan 86b992d
Add since
carolinan 441a72d
Add color block supports
carolinan 1181836
Merge branch 'trunk' into try/playlist2
carolinan 3cf80ae
Add __next40pxDefaultSize and __nextHasNoMarginBottom to various cont…
carolinan 862c4f1
Use the option for the experimental blocks.
carolinan 880db38
WIP: Use the interactivity API.
carolinan 69e1629
Build the core-blocks.md doc to update the block supports
carolinan 9e60534
Merge branch 'trunk' into try/playlist2
carolinan 8f9106e
Index.php: Re-add the conditions for the block options.
carolinan e0390ec
Index.php: update spacing
carolinan 234738d
Playlist: Add caption
carolinan 6d4a85f
Re-build docs
carolinan eea92d6
Merge branch 'trunk' into try/playlist2
carolinan 95c425f
Re-add the autoplay of the next track when one track ends.
carolinan 66f32d1
Remove the track title from the current track
carolinan 70b1337
WIP: Update styles
carolinan e54fa51
Update style.scss
carolinan 86592aa
Merge branch 'trunk' into try/playlist2
carolinan 5999fec
Add placeholder artist and album, remove placeholder image
carolinan 3fa03b8
Update colors to work better when the user selects text and backgroun…
carolinan e8cfd68
Merge branch 'trunk' into try/playlist2
carolinan 244b979
Merge branch 'trunk' into try/playlist2
carolinan c4b50bd
Merge branch 'trunk' into try/playlist2
carolinan 3b18ebc
WIP: Use inner blocks for the tracks
carolinan 7ef20d0
Track: Use "Replace" instead of "Edit" in the toolbar
carolinan f84a718
Track: Set the text align on the button to left.
carolinan 6ef1e5d
Track: Update block supports
carolinan 7ad6159
Playlist: Try showing the inserter at the bottom of the block.
carolinan 7a7b9ec
Adjust the track button CSS class and move the appender
carolinan 01df824
Fix the invalid HTML of the list on the front
carolinan f8a7492
Track: update block supports
carolinan f1c7786
WIP: Prevent duplicate tracks
carolinan d75c10d
Move the tracklist inside `<Disabled>`
carolinan a86d15f
Playlist: Rename the images attribute to showImages
carolinan 10b5551
Revert placing the tracklist within Disabled since it prevented addin…
carolinan bf141aa
Revert the prevention of duplicate tracks
carolinan 5c2da88
Playlist: rename the tracklist block attribute to showTracklist
carolinan 358ed29
Playlist: Update the tracks block attribute when the user changes pos…
carolinan 2955deb
Playlist: Fix the display of the album image
carolinan a6226fc
Re-add the track title to the current track.
carolinan 5f23da3
Try to fix a JS error when a track is re-positioned.
carolinan 845e9ed
Playlist: Add the current title as a data-wp-text
carolinan 2a0329e
Playlist: Correct the position of the artist and album for the curren…
carolinan 5e50c96
Track: Try to improve responsiveness
carolinan 389e86c
First iteration of adding the album cover image to the track
carolinan 6d2cd60
Adjust the CSS
carolinan c467dbf
Update the monitoring of changes to inner blocks
carolinan 3580672
Update how the current track is managed
carolinan 2512870
Update the appender, prevent grouping inner blocks
carolinan 6990862
Prevent PHP notices when the current track is the media placeholder
carolinan 9ac5f28
Merge branch 'trunk' into try/playlist2
carolinan 31ab787
Move the current track to a new constant
carolinan c28bc1e
Adjust the styling of the placeholder, removing the border
carolinan 6228715
Display a placeholder for the current track
carolinan 8f771f3
Update how the current track is handled
carolinan 0093fe2
Remove a constant that was only used once
carolinan 1f3bcf4
Add a comment about sanitizing HTML in data from the media library
carolinan 27237cc
Add checks for the media_details attachment data
carolinan 76a6444
Playlist track: Update the MediaReplaceFlow
carolinan 377964d
Playlist: Update MediaReplaceFlow
carolinan dd11826
Merge branch 'trunk' into try/playlist2
carolinan b3c49bf
Playlist: Try to reduce the number of undo steps
carolinan 0e472b8
Playlist MediaReplaceFlow: remove "value"
carolinan 6d5d15d
Track: introduce blob management and clean up the MediaReplaceFlow
carolinan 808cc8e
Playlist: Try to solve the duplcation of existing tracks on file uplo…
carolinan 4249fa5
WIP: Make the block actually dynamic
carolinan 122c6f8
WIP: Add the markup for the current track at the top of the playlist
carolinan deb34b6
Playlist track: Save changes to the title of the track using useEntit…
carolinan efb61b5
Remove imperative code and add server array
luisherranz 45bc81f
Add missing derived state in the server
luisherranz 6b37af5
Merge branch 'trunk' into try/playlist2
carolinan 0aeb5db
WIP: re-add the block attributes
carolinan 95dc588
Merge branch 'trunk' into try/playlist2
carolinan be203fb
Merge branch 'trunk' into try/playlist2
carolinan 652f58b
Play the track that is being switched to.
carolinan da8af7e
Add a placeholder for missing track titles on the front of the site
carolinan 015e7f9
Merge branch 'trunk' into try/playlist2
carolinan 6150d0e
Merge branch 'trunk' into try/playlist2
carolinan 4f7eca3
Merge branch 'trunk' into try/playlist2
carolinan 5e92ce9
Merge branch 'trunk' into try/playlist2
carolinan dfb1e1d
Merge branch 'trunk' into try/playlist2
carolinan 3c69a5c
Merge branch 'trunk' into try/playlist2
carolinan 9c3d720
Try to solve merge conflict
carolinan c6e5029
Merge branch 'trunk' into try/playlist2
carolinan 7c4600c
Try to implement the unique id
carolinan 1b18b17
Update index.php
carolinan 60642d1
Try removing the tracks block attribute and only use the inner blocks
carolinan 998a271
Merge branch 'trunk' into try/playlist2
carolinan 2e1ae93
Let long titles wrap and not overflow the container
carolinan 675f87c
remove test code
carolinan 5246288
Ensure that each inner block has a unique ID even when duplicated
carolinan df69608
Merge branch 'trunk' into try/playlist2
carolinan 17313df
Don't include the media placeholder in the tracklist
carolinan d895e2a
Fix the options to hide the tracklist and artist name
carolinan cd4f23f
Tracklist: replace innerBlocksProps with innerBlocksProps.children
carolinan 53a65f9
Re-add the early return.
carolinan a829b43
Fix the CSS for hidden tracklist
carolinan 49c7486
Update style.scss
carolinan 69a0508
Update since to 6..9.0
carolinan 095e39d
Playlist track: correct the data-wp-context in the editor
carolinan e86aad2
Try to isolate each playlist block in the global state by using a uni…
carolinan b5e43ee
Merge branch 'trunk' into try/playlist2
carolinan 366c531
Merge branch 'trunk' into try/playlist2
carolinan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Track: introduce blob management and clean up the MediaReplaceFlow
The purpose of this change is to improve the user experience when uploading new files and when undoing the insertion of new tracks. This is copied from recent changes made to the audio and video blocks.
- Loading branch information
commit 6d5d15d183945d647fe14833591aa7a49946fbc0
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the difference between
acceptandallowedTypes?